Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

MM-T3294 MM-23359 Add e2e test for ctrl cmd k open dm with mouse #6104

Conversation

josephk96
Copy link
Contributor

@josephk96 josephk96 commented Aug 9, 2020

Summary

  • Created an e2e test that searches for a user by using the ctrl/cmd+K shortcut, searches for a user and clicks on that user's name to open a DM, logout, login as the second user, and check that the DM exists

Ticket Link
Jira: https://mattermost.atlassian.net/browse/MM-23359
Test case: https://automation-test-cases.vercel.app/test/MM-T3294

@josephk96 josephk96 force-pushed the MM-23359-ctrl-cmd-k-open-dm-with-mouse branch from 779155c to 2c56b04 Compare August 9, 2020 10:23
@josephk96 josephk96 force-pushed the MM-23359-ctrl-cmd-k-open-dm-with-mouse branch from 2c56b04 to d62f4c3 Compare August 9, 2020 10:24
Copy link
Member

@saturninoabril saturninoabril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @josephk96! Please see comments.

@saturninoabril saturninoabril changed the title MM-23359 Add e2e test for ctrl cmd k open dm with mouse MM-23359 MM-T3294 Add e2e test for ctrl cmd k open dm with mouse Aug 10, 2020
@saturninoabril saturninoabril added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester Hackfest labels Aug 10, 2020
@josephk96
Copy link
Contributor Author

Thanks for your comments, @saturninoabril ! I implemented the changes that you suggested.
The testing library that you linked to is pretty cool. We also seem to have more custom commands that I thought haha :)

Copy link
Member

@saturninoabril saturninoabril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@josephk96 Thanks for the updates! LGTM except for the last one (my bad in suggesting incomplete key).
Yep, we have almost 200 commands currently and needs to better organize those.

@saturninoabril saturninoabril removed the 2: Dev Review Requires review by a core commiter label Aug 10, 2020
Copy link
Contributor

@josephbaylon josephbaylon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. All tests passed. Thanks @josephk96 !!

@saturninoabril saturninoabril added the Awaiting Submitter Action Blocked on the author label Aug 10, 2020
@josephbaylon josephbaylon added 4: Reviews Complete All reviewers have approved the pull request and removed Awaiting Submitter Action Blocked on the author 3: QA Review Requires review by a QA tester labels Aug 10, 2020
@josephbaylon josephbaylon merged commit 6db6955 into mattermost:master Aug 10, 2020
@josephk96
Copy link
Contributor Author

Thanks @josephbaylon for the review!
@saturninoabril If you decide to document the available custom commands, I'd love to help out!

@saturninoabril
Copy link
Member

Thanks @josephk96! Awesome! After the Hackfest, we'll be launching a separate campaign for it. Just need to write the guidelines. But basically, it's similar to how #5953 is implemented.

@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Aug 10, 2020
@josephbaylon josephbaylon changed the title MM-23359 MM-T3294 Add e2e test for ctrl cmd k open dm with mouse MM-T3294 MM-23359 Add e2e test for ctrl cmd k open dm with mouse Aug 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation Hackfest
Projects
None yet
4 participants