This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
MM-20543 manage timezones ts #6051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanzei
added
2: Dev Review
|
Hi @sridhar02, thanks for the pull request! It looks like you still have some type-checking and style-checking errors present. Make sure to run Can you fix those errors before I have a look? When you're done you can @ mention me and I'll have a look. |
sridhar02
force-pushed
the
MM-20543_ManageTimezones-ts
branch
from
fc90330
to
504a4ef
Compare
|
@devinbinnie, I have fixed all the errors in this PR can u have look at it. |
devinbinnie
approved these changes
Aug 6, 2020
There was a problem hiding this comment.
Looks good to me! Just one small non-blocking comment.
Thanks @sridhar02!
components/user_settings/display/manage_timezones/manage_timezones.tsx
Outdated
Show resolved
Hide resolved
hmhealey
suggested changes
Aug 7, 2020
components/user_settings/display/manage_timezones/manage_timezones.tsx
Outdated
Show resolved
Hide resolved
sridhar02
force-pushed
the
MM-20543_ManageTimezones-ts
branch
from
3c530d2
to
66848c9
Compare
hmhealey
approved these changes
Aug 11, 2020
stevemudie
added
QA Review Done
and removed
3: QA Review
hmhealey
added
the
4: Reviews Complete
|
@sridhar02 Thanks again for your work on this! |
amyblais
added
Changelog/Not Needed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Migrate 'components/user_settings/display/manage_timezones' module and associated tests to TypeScript
Ticket Link
Fixes mattermost/mattermost#13698
JIRA Ticket : https://mattermost.atlassian.net/browse/MM-20543