This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
[MM-27168] Set -webkit-fill-available when on iOS Safari and 100vh otherwise #6010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also set first div child of admin console as height 100%
fmunshi
added
2: Dev Review
added 2 commits
July 29, 2020 17:01
amyblais
added
the
CherryPick/Approved
|
@asaadmahmood @calebroseland Kind note that this PR is for v5.25 dot release, |
asaadmahmood
approved these changes
Jul 30, 2020
calebroseland
approved these changes
Jul 30, 2020
lindy65
added
the
Setup Cloud Test Server
lindy65
approved these changes
Jul 30, 2020
There was a problem hiding this comment.
Thanks @fmunshi - I tested on Win10 Chrome versions 84.0.4147.89 and 84.0.4147.105 as well as iPad and did not find any issues. I am able to scroll content in the system console. The original bug in #5659 is also (still) fixed.
Jelena helped test the following:
Chrome Version 83.0.4103.116 macOS
Safari Version 13.1.1 macOS
Sys Console main view scrolls on both Chrome and Safari
lindy65
added
4: Reviews Complete
|
Test server destroyed |
mattermost-build
pushed a commit
to mattermost-build/mattermost-webapp
that referenced
this pull request
Jul 30, 2020
…herwise (mattermost#6010) * Set -webkit-fill-available when on iOS Safari Also set first div child of admin console as height 100% * Unneeded ampersand * This 100% does nothing (cherry picked from commit 630ce20)
mattermod
added
CherryPick/Done
fmunshi
added a commit
that referenced
this pull request
Jul 30, 2020
…herwise (#6010) * Set -webkit-fill-available when on iOS Safari Also set first div child of admin console as height 100% * Unneeded ampersand * This 100% does nothing
fmunshi
added a commit
that referenced
this pull request
Jul 30, 2020
…herwise (#6010) (#6022) * Set -webkit-fill-available when on iOS Safari Also set first div child of admin console as height 100% * Unneeded ampersand * This 100% does nothing (cherry picked from commit 630ce20) Co-authored-by: Farhan Munshi <[email protected]>
amyblais
added
Changelog/Done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Since webkit-touch-callout is only supported on iOS Safari (see https://developer.mozilla.org/en-US/docs/Web/CSS/-webkit-touch-callout) this will make the original fix of
height: -webkit-fill-available;apply when its needed and leave desktop chrome / other browsers unchanged.I dont have an iOS device to test this on so I havent actually confirmed that this works on iOS safari but I can confirm that it doesnt break anything on chrome / any other desktop browsers
Milestone labeled as 5.26 but will also cherry-pick this to 5.25 when tested
Ticket Link