[MM-20534] migrate 'components/create team/components/team url' module and associated tests to type script #5983

jakubnovak998 · 2020-07-23T20:31:40Z

Summary

Rename the files to their associated TypeScript extensions (ie. js to ts, jsx to tsx)
Update any components using those to the correct imports
Fix any errors generated by the TypeScript compiler. You can run make check-types to display any errors.

Ticket Link

…'components/create_team/components/team_url'-module-and-associated-tests-to-TypeScript

devinbinnie · 2020-07-30T18:56:10Z

Hey @jakubnovak998, thanks for the pull request!

It looks like there are some type-checking errors still occuring. Make sure to run make check-types before pushing up your code. Can you fix up those errors before I have a look at the PR?

If you have any questions or need any help, feel free to ask :)

…'components/create_team/components/team_url'-module-and-associated-tests-to-TypeScript

jakubnovak998 · 2020-08-08T08:44:28Z

Hey @devinbinnie,
Thanks, I just fixed them. The PR is ready for review.

devinbinnie

Thanks for the PR @jakubnovak998, I've added some comments for you to review.

devinbinnie · 2020-08-10T13:29:57Z

components/create_team/components/team_url/team_url.tsx


- constructor(props) {
+export default class TeamUrl extends React.PureComponent<Props, State> {
+ public constructor(props: Props) {


Is there a specific reason this is public? Usually we're not creating new instances of this component in JS/TS.

No, there isn't any specific reason. I'll remove it.

devinbinnie · 2020-08-10T13:30:56Z

components/create_team/components/team_url/team_url.tsx

 teamSignup.team.type = 'O';
 teamSignup.team.name = name;

- const {exists} = await checkIfTeamExists(name);
+ const {exists}: any = await checkIfTeamExists(name);


This should be {exists: boolean} instead of any.

It causes the problem that exists is not visible in if statement on 143 line and it does not exist on type ActionFunc.

I think you might want to change the return type of checkIfTeamExists in your type declaration. It could just look something like: Promise<{exists: boolean}>.

devinbinnie · 2020-08-10T13:32:17Z

components/create_team/components/team_url/team_url.tsx

@@ -140,7 +151,7 @@ export default class TeamUrl extends React.PureComponent {
 return;
 }

- const {data, error} = await createTeam(teamSignup.team);
+ const {data, error}: any = await createTeam(teamSignup.team);


This should be {data: Team, error: Client4Error} instead of any

It causes the same problems as exists change

You can do the same thing here as above.

devinbinnie · 2020-08-10T13:33:28Z

components/create_team/components/team_url/team_url.tsx

 e.preventDefault();
 e.currentTarget.select();
 }

- render() {
+ public render() {


Nit: This doesn't need to be public, we're never calling it outside of the scope of this class.

devinbinnie · 2020-08-10T13:34:26Z

components/create_team/components/team_url/team_url.tsx

@@ -261,7 +272,7 @@ export default class TeamUrl extends React.PureComponent {
 type='submit'
 bsStyle='primary'
 disabled={this.state.isLoading}
- onClick={this.submitNext}
+ onClick={this.submitNext as any}


This shouldn't need to be declared as any.

- solve exists, data/error is not visible and do not exist on ActionFunc - remove public from render and constructor - remove as any from button's onclick

…'components/create_team/components/team_url'-module-and-associated-tests-to-TypeScript

devinbinnie

This is looking great, thanks again @jakubnovak998.
Just two small comments to resolve :)

components/create_team/components/team_url/team_url.tsx

devinbinnie · 2020-08-24T13:24:50Z

components/create_team/components/team_url/team_url.tsx

@@ -261,7 +275,7 @@ export default class TeamUrl extends React.PureComponent {
 type='submit'
 bsStyle='primary'
 disabled={this.state.isLoading}
- onClick={this.submitNext}
+ onClick={(e: any) => this.submitNext(e)}


e here should be of type React.MouseEvent<HTMLDivElement>

stevemudie

LGTM

- remove type declaration from creatTeamData const - change type of e to React.MouseEvent

- type of event problem resolve

sudheerDev · 2020-08-27T09:30:52Z

@jakubnovak998 Hey there is a lint error and a type check error. Can you have a look

- resolve lint errors - revert error type to any

mattermod · 2020-09-07T01:01:39Z

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

/cc @jasonblais @jfrerich

devinbinnie

LGTM, thanks @jakubnovak998!

devinbinnie · 2020-09-08T13:04:00Z

/update-branch

…omponents/team_url'-module-and-associated-tests-to-TypeScript

devinbinnie · 2020-09-08T13:06:15Z

@sudheerDev Can you have a look when you get some time?

sudheerDev

LGTM

…e and associated tests to type script (#5983) * MM-20534 migrate team_url module and associated tests to TypeScript * MM-20534 fix type errors * MM-20534 add snapshot * MM-20534 corrections after test fail * MM-20534 changes: - solve exists, data/error is not visible and do not exist on ActionFunc - remove public from render and constructor - remove as any from button's onclick * MM-20534 fix test problem * MM-20534 changes after review: - remove type declaration from creatTeamData const - change type of e to React.MouseEvent * MM-20534 changes: - type of event problem resolve * MM-20534 changes: - resolve lint errors - revert error type to any Co-authored-by: Mattermod <[email protected]>

jakubnovak998 added 2 commits July 23, 2020 22:22

MM-20534 migrate team_url module and associated tests to TypeScript

b9890b1

Merge remote-tracking branch 'upstream/master' into MM-20534-Migrate-…

37955c2

…'components/create_team/components/team_url'-module-and-associated-tests-to-TypeScript

hanzei requested a review from devinbinnie July 24, 2020 06:33

hanzei added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Jul 24, 2020

devinbinnie added the Work in Progress Not yet ready for review label Jul 24, 2020

mattermost deleted a comment from hanzei Jul 29, 2020

jakubnovak998 added 5 commits July 31, 2020 22:43

MM-20534 fix type errors

eea21c7

Merge remote-tracking branch 'upstream/master' into MM-20534-Migrate-…

823f8b0

…'components/create_team/components/team_url'-module-and-associated-tests-to-TypeScript

MM-20534 add snapshot

4c5e681

Merge remote-tracking branch 'upstream/master' into MM-20534-Migrate-…

7d4b2fa

…'components/create_team/components/team_url'-module-and-associated-tests-to-TypeScript

MM-20534 corrections after test fail

1f43585

jakubnovak998 closed this Aug 8, 2020

jakubnovak998 reopened this Aug 8, 2020

devinbinnie removed the Work in Progress Not yet ready for review label Aug 10, 2020

devinbinnie suggested changes Aug 10, 2020

View reviewed changes

jakubnovak998 added 4 commits August 13, 2020 22:49

MM-20534 changes:

6116054

- solve exists, data/error is not visible and do not exist on ActionFunc - remove public from render and constructor - remove as any from button's onclick

Merge remote-tracking branch 'upstream/master' into MM-20534-Migrate-…

eac4135

…'components/create_team/components/team_url'-module-and-associated-tests-to-TypeScript

MM-20534 fix test problem

d56f572

Merge remote-tracking branch 'upstream/master' into MM-20534-Migrate-…

9268f14

…'components/create_team/components/team_url'-module-and-associated-tests-to-TypeScript

devinbinnie suggested changes Aug 24, 2020

View reviewed changes

devinbinnie requested review from sudheerDev and stevemudie August 24, 2020 13:25

stevemudie approved these changes Aug 24, 2020

View reviewed changes

stevemudie added QA Review Done and removed 3: QA Review Requires review by a QA tester labels Aug 24, 2020

jakubnovak998 added 2 commits August 25, 2020 21:50

MM-20534 changes after review:

4f330bd

- remove type declaration from creatTeamData const - change type of e to React.MouseEvent

MM-20534 changes:

87dc416

- type of event problem resolve

MM-20534 changes:

536f7c9

- resolve lint errors - revert error type to any

mattermod added the Lifecycle/1:stale label Sep 7, 2020

devinbinnie approved these changes Sep 8, 2020

View reviewed changes

Merge branch 'master' into MM-20534-Migrate-'components/create_team/c…

253a309

…omponents/team_url'-module-and-associated-tests-to-TypeScript

devinbinnie removed the Lifecycle/1:stale label Sep 8, 2020

sudheerDev approved these changes Sep 8, 2020

View reviewed changes

sudheerDev merged commit 3afd4b4 into mattermost:master Sep 8, 2020

sudheerDev added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter labels Sep 8, 2020

sudheerDev added this to the v5.28 milestone Sep 8, 2020

amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Sep 8, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MM-20534] migrate 'components/create team/components/team url' module and associated tests to type script #5983

[MM-20534] migrate 'components/create team/components/team url' module and associated tests to type script #5983

jakubnovak998 commented Jul 23, 2020 •

edited by hanzei

Loading

devinbinnie commented Jul 30, 2020

jakubnovak998 commented Aug 8, 2020

devinbinnie left a comment

devinbinnie Aug 10, 2020

jakubnovak998 Aug 12, 2020

devinbinnie Aug 10, 2020

jakubnovak998 Aug 12, 2020

devinbinnie Aug 13, 2020

devinbinnie Aug 10, 2020

jakubnovak998 Aug 12, 2020

devinbinnie Aug 13, 2020

devinbinnie Aug 10, 2020

devinbinnie Aug 10, 2020

devinbinnie left a comment

devinbinnie Aug 24, 2020

stevemudie left a comment

sudheerDev commented Aug 27, 2020

mattermod commented Sep 7, 2020

devinbinnie left a comment

devinbinnie commented Sep 8, 2020

devinbinnie commented Sep 8, 2020

sudheerDev left a comment

[MM-20534] migrate 'components/create team/components/team url' module and associated tests to type script #5983

[MM-20534] migrate 'components/create team/components/team url' module and associated tests to type script #5983

Conversation

jakubnovak998 commented Jul 23, 2020 • edited by hanzei Loading

Summary

Ticket Link

devinbinnie commented Jul 30, 2020

jakubnovak998 commented Aug 8, 2020

devinbinnie left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

devinbinnie left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stevemudie left a comment

Choose a reason for hiding this comment

sudheerDev commented Aug 27, 2020

mattermod commented Sep 7, 2020

devinbinnie left a comment

Choose a reason for hiding this comment

devinbinnie commented Sep 8, 2020

devinbinnie commented Sep 8, 2020

sudheerDev left a comment

Choose a reason for hiding this comment

jakubnovak998 commented Jul 23, 2020 •

edited by hanzei

Loading