Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

Cypress/E2E: Fix accessibility input fields #5961

Merged
merged 3 commits into from
Jul 22, 2020
Merged

Cypress/E2E: Fix accessibility input fields #5961

merged 3 commits into from
Jul 22, 2020

Conversation

josephbaylon
Copy link
Contributor

Summary

  • This is just a workaround to making sure highlighted item is correct; this test works for me locally without changes so workaround is for cypress only

Ticket Link

None - master only

Screen Shot 2020-07-21 at 11 09 04 AM

@josephbaylon josephbaylon added the 3: QA Review Requires review by a QA tester label Jul 21, 2020
@josephbaylon josephbaylon requested a review from prapti July 21, 2020 18:10
prapti
prapti approved these changes Jul 22, 2020
View reviewed changes
Copy link
Contributor

@prapti prapti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@prapti
Copy link
Contributor

prapti commented Jul 22, 2020 •
edited
Loading

@josephbaylon Is a second reviewer not needed here (process wise)?

@saturninoabril saturninoabril added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Jul 22, 2020
@saturninoabril saturninoabril merged commit 25f3e3c into mattermost:master Jul 22, 2020
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Jul 22, 2020
@josephbaylon josephbaylon deleted the fix-accessibility-input-fields branch July 22, 2020 15:06
@josephbaylon
Copy link
Contributor Author

@josephbaylon Is a second reviewer not needed here (process wise)?

@prapti Didn't notice Rohitesh wasn't added properly. Saturn made it in time though 🎉

@saturninoabril
Copy link
Member

Per offline discussion with Joseph, I'll cherry-pick this into release-5.26.

@saturninoabril saturninoabril added this to the v5.26 milestone Jul 22, 2020
saturninoabril pushed a commit to saturninoabril/mattermost-webapp that referenced this pull request Jul 22, 2020
@saturninoabril
Cypress/E2E: Fix accessibility input fields (mattermost#5961)
3b089f3 
* Try to fix timezone display mode flakiness

* Fix accessibility input fields spec
saturninoabril pushed a commit that referenced this pull request Jul 22, 2020
@saturninoabril
Cypress/E2E: Fix accessibility input fields (#5961)
c97737e 
* Try to fix timezone display mode flakiness

* Fix accessibility input fields spec
@saturninoabril saturninoabril added the CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone label Jul 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@prapti prapti prapti approved these changes

@saturninoabril saturninoabril saturninoabril approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone Docs/Not Needed Does not require documentation
Projects
None yet
Milestone
v5.26.0
4 participants
@josephbaylon @prapti @saturninoabril @amyblais