Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

MM-26410/MM-26825 Switch to new isFavoriteChannel selector #5917

Merged
merged 4 commits into from
Jul 22, 2020
Merged

MM-26410/MM-26825 Switch to new isFavoriteChannel selector #5917

merged 4 commits into from
Jul 22, 2020

Conversation

hmhealey
Copy link
Member

@hmhealey hmhealey commented Jul 17, 2020 •
edited
Loading

This stops usage of the now-renamed isFavoriteChannelOld utility and switches everything to use the newly-relocated isFavoriteChannel selector, but more importantly, it includes the changes made to mattermost-redux in mattermost/mattermost-redux#1197.

Ticket Link

https://mattermost.atlassian.net/browse/MM-26410
https://mattermost.atlassian.net/browse/MM-26825

Related Pull Requests

mattermost/mattermost-redux#1197
mattermost/mattermost#15048

@hmhealey hmhealey added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Jul 17, 2020
@hmhealey hmhealey added this to the v5.26 milestone Jul 17, 2020
@hmhealey hmhealey mentioned this pull request Jul 17, 2020
Merged
@hmhealey hmhealey requested review from enahum and removed request for devinbinnie July 17, 2020 00:52
@hmhealey hmhealey added the Do Not Merge/Awaiting PR Awaiting another pull request before merging (e.g. server changes) label Jul 17, 2020
@hmhealey hmhealey mentioned this pull request Jul 17, 2020
Merged
@amyblais amyblais added the CherryPick/Approved Meant for the quality or patch release tracked in the milestone label Jul 17, 2020
@hmhealey hmhealey removed the 2: Dev Review Requires review by a core commiter label Jul 20, 2020
@hmhealey hmhealey requested a review from ogi-m July 20, 2020 13:47
@hmhealey hmhealey added Setup Cloud Test Server Setup a test server using Mattermost Cloud and removed Do Not Merge/Awaiting PR Awaiting another pull request before merging (e.g. server changes) Setup Cloud Test Server Setup a test server using Mattermost Cloud labels Jul 20, 2020
@mm-cloud-bot
Copy link

Test server destroyed

@hmhealey
Copy link
Member Author

This changes should be testable on the server PR here: mattermost/mattermost#15048

@hmhealey hmhealey mentioned this pull request Jul 21, 2020
Closed
ogi-m
ogi-m approved these changes Jul 21, 2020
View reviewed changes
Copy link

@ogi-m ogi-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on the server PR.

@ogi-m ogi-m added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Jul 21, 2020
@hmhealey hmhealey merged commit ca0ebbd into master Jul 22, 2020
@hmhealey hmhealey deleted the MM_26410-favourites_syncing branch July 22, 2020 13:40
@mattermost-build mattermost-build mentioned this pull request Jul 22, 2020
Merged
@mattermod mattermod added CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone and removed CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Jul 22, 2020
hmhealey added a commit that referenced this pull request Jul 22, 2020
@mattermost-build @hmhealey
Automated cherry pick of #5917 (#5965)
ab21a8e 
* MM-26410 Switch to new isFavoriteChannel selector

* Update mattermost-redux to master

* Switch mattermost-redux to release-5.26 branch

Co-authored-by: Harrison Healey <[email protected]>
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Jul 22, 2020
@ogi-m ogi-m added the Tests/Done Release tests have been written label Aug 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fmunshi fmunshi fmunshi approved these changes

@enahum enahum enahum approved these changes

@ogi-m ogi-m ogi-m approved these changes

Assignees

@hmhealey hmhealey

Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone Docs/Not Needed Does not require documentation Tests/Done Release tests have been written
Projects
None yet
Milestone
v5.26.0
7 participants
@hmhealey @mm-cloud-bot @fmunshi @enahum @ogi-m @mattermod @amyblais