This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
MM-26733 - Export Textbox so plugins can use it #5894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2e6818a
to
23d9a99
Compare
scastillo
reviewed
Jul 21, 2020
agarciamontoro
approved these changes
Jul 22, 2020
| window.openInteractiveDialog = openInteractiveDialog; | ||
| window.WebappUtils = {browserHistory}; | ||
| window.Components = {Textbox}; |
There was a problem hiding this comment.
The Components namespace is nice :)
lieut-data
approved these changes
Jul 22, 2020
components/textbox/textbox.tsx
Outdated
| @@ -234,6 +235,7 @@ export default class Textbox extends React.PureComponent<Props> { | |||
| </div> | |||
| ); | |||
| } | |||
| const inputComponent = this.props.inputComponent || AutosizeTextarea; | |||
There was a problem hiding this comment.
Should we configure this in defaultProps instead?
There was a problem hiding this comment.
Yes, good idea! And I took out the null as a possible value of inputComponent (defaultProps will not replace a null value).
lieut-data
approved these changes
Jul 22, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Textbox'sAutosizeTextArea.QuickInputwe don't need thechannelIdso remove it, and if we're not using anAutosizeTextAreawe don't need to pass in theonHeightChangeprop (these were causing warnings went sent to a plain input, and I wanted to clean them up).window.components.Textbox? -- doneTicket Link