Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

MM-23699: Remove backbutton for when invalid callback url #5884

Merged
merged 3 commits into from
Jul 29, 2020
Merged

MM-23699: Remove backbutton for when invalid callback url #5884

merged 3 commits into from
Jul 29, 2020

Conversation

sbishel
Copy link
Member

@sbishel sbishel commented Jul 10, 2020 •
edited
Loading

Summary

OAuth2.0: Incorrect Callback URL during authentication allows user to go "Back to Mattermost" in the authentication window. This PR removes the "Back to Mattermost" button.

Ticket Link

https://mattermost.atlassian.net/browse/MM-23699

Related Pull Requests

mattermost/mattermost#15001

Screenshots

Screen Shot 2020-07-09 at 6 41 35 PM

@sbishel sbishel mentioned this pull request Jul 10, 2020
Merged
@sbishel sbishel added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Jul 10, 2020
@sbishel sbishel mentioned this pull request Jul 10, 2020
Closed
@fmunshi fmunshi removed the 2: Dev Review Requires review by a core commiter label Jul 14, 2020
@fmunshi fmunshi requested a review from srkgupta July 14, 2020 21:42
@fmunshi
Copy link
Contributor

fmunshi commented Jul 14, 2020

/update-branch

@srkgupta srkgupta added this to the v5.27 milestone Jul 21, 2020
srkgupta
srkgupta approved these changes Jul 28, 2020
View reviewed changes
Copy link
Contributor

@srkgupta srkgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the PR along with its dependent PR and the issue is fixed now and is working fine. Approving the PR.

@srkgupta srkgupta added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Jul 28, 2020
@sbishel
Copy link
Member Author

sbishel commented Jul 28, 2020

/update-branch

@sbishel sbishel merged commit f5d9368 into master Jul 29, 2020
@sbishel sbishel deleted the MM-23699-remove-backbutton branch July 29, 2020 01:36
@amyblais amyblais added the CherryPick/Approved Meant for the quality or patch release tracked in the milestone label Aug 13, 2020
@sbishel
Copy link
Member Author

sbishel commented Aug 17, 2020

/cherry-pick release-5.27

mattermost-build pushed a commit to mattermost-build/mattermost-webapp that referenced this pull request Aug 17, 2020
@sbishel @mattermost-build
Remove backbutton for when invalid callback url (mattermost#5884)
496e825 
Co-authored-by: Mattermod <[email protected]>
(cherry picked from commit f5d9368)
@mattermost-build mattermost-build mentioned this pull request Aug 17, 2020
Merged
@mattermod mattermod added CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone and removed CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Aug 17, 2020
@amyblais amyblais added Changelog/Done Required changelog entry has been written Docs/Not Needed Does not require documentation labels Aug 17, 2020
sbishel added a commit that referenced this pull request Aug 18, 2020
@mattermost-build @sbishel
Remove backbutton for when invalid callback url (#5884) (#6177)
de17c06 
Co-authored-by: Mattermod <[email protected]>
(cherry picked from commit f5d9368)

Co-authored-by: Scott Bishel <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@srkgupta srkgupta srkgupta approved these changes

@fmunshi fmunshi fmunshi approved these changes

@catalintomai catalintomai catalintomai approved these changes

Assignees

@sbishel sbishel

Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Done Required changelog entry has been written CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone Docs/Not Needed Does not require documentation
Projects
None yet
Milestone
v5.27.0
6 participants
@sbishel @fmunshi @srkgupta @catalintomai @mattermod @amyblais