This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
Sidebar V2 Phase 2 #5854
Merged
Sidebar V2 Phase 2 #5854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tal_sidebar_features-v2
…iful-dnd (#5217) * WIP * Restrict dragging based on category requirements * isDraggingCategory * Allow channels to be dropped on top of category headers * Do not allow DMs to be re-ordered within the DM category * Show cannot drop cursor when dragging in an area that cannot be dropped into * Expand category when dragging over the header if the item can be dropped in * Lint, type and test fixes * Fixed dragging channels on the desktop * WIP - hooks to change the order * Mock persistent drag, doesn't fully work * Redux change * Collapse categories on drag so that you're not dragging a huge block * Category dragging and collapsing working * Use current favorites preferences when dragging in/out of favorites * Dim and collapse categories that the current channel cannot be dragged into, also fixed channels that wouldn't collapse during dragging * Refactoring and cleanup * Styling around channels and categories when dragging * Couple fixes * Fixes as per review with Eric/Andrew * Redux update * PR feedback * Merge'd * Fixed the category header outline * Drag n Drop E2E test draft * PR feedback * Some accessibility fixes * More accessibility fixes * More accessibility fixes * Style fix * Removed inline styles on sidebar-channel and added classes to toggle * Even more accessibility fixes * Moved to attribute * DnD E2E test fixes * Test fix * Remove unnecessary code * Remove unnecessary TODO Co-authored-by: mattermod <[email protected]>
…5378) * [MM-23966] Added create category modal * [MM-23966] Genericized create category modal so it can be used for rename as well * [MM-23967] Added a Delete Category modal * Update icon pack * Set correct custom category icon * Added mock new category * Use sidebar_dnd_poc for redux * PR feedback * PR feedback * PR feedback * PR feedback * Fixed a var
…tal_sidebar_features-v2
* Some preliminary styling and fixes needed for submenus * Base menu for channels * Update icon pack * Allow submenus to open up, add support for channel menus opening up * Some style fixes * More style fixes * Rough category menu * Refactored menus into sub component and setup some styles * Lint, type and test fixes * Translations and a few more style fixes * Another submenu style fix * Copy link functionality * Add members functionality * Move to category menu and style * Update snapshots * PR feedback * Remove unnecessary translations * PR feedback * PR feedback * Lint fix * Basic keyboard navigation for submenus * Unit tests for quick menus * Lint fix * PR feedback * Style fixes * PR feedback * More PR feedback * Account for shortened viewport * Temporary menu fixes for mobile * PR feedback
…tal_sidebar_features-v2
* Main hookups and merging of 3 features * Added markers for replacement redux functions * A plethora of UX fixes * Fix for the Delete Category menu item and i18n fix * Feedback from Andrew * Initial move to mattermost-redux * Some additional fixes * Lint, type and style fixes * PR feedback * i18n fix * Test fix * Fixed the mention badge position/hover state * Added a couple more tests * Fixed for padding on the right side of overflowed channel names * Fixed an issue where dropped categories float to the wrong place before snapping back * Fixed small alignment issue for GM icons * Slight adjustment * PR feedback * PR feedback * Update Sorting to CategorySorting * Update sass/layout/_sidebar-left.scss Co-authored-by: Dean Whillier <[email protected]> Co-authored-by: Dean Whillier <[email protected]>
* [MM-25509] Setup channel menu to use new modal style * Refactor for HH * Lint fixes Co-authored-by: mattermod <[email protected]>
* [MM-24705] Add telemetry for Experimental Sidebar Phase 2 * Lint fixes Co-authored-by: mattermod <[email protected]>
hmhealey
removed
the
Setup Cloud Test Server
|
/check-cla |
hmhealey
added
Setup Cloud Test Server
|
FYI, this test server uses the master branch of the server, so the sidebar will be blank when you turn on the new sidebar. I'll try to figure out why this is happening... |
hmhealey
removed
the
Setup Cloud Test Server
|
Test server destroyed |
deanwhillier
approved these changes
Jul 6, 2020
|
/update-branch |
hahmadia
removed
the
Do Not Merge/Awaiting PR
hmhealey
added
the
4: Reviews Complete
Comment on lines
+28
to
+30
| cy.apiLogin('user-1'); | ||
|
|
||
| cy.visit('/'); |
There was a problem hiding this comment.
Non-blocking and we can fix post-merge into master. Instead of using hard-coded user data like user-1, in the future please something like:
cy.apiInitSetup({loginAfter: true}).then(({team}) => {
cy.visit(`/${team.name}/channels/town-square`);
});There was a problem hiding this comment.
I'll make a note of that. I forgot that we actually had any e2e tests for this since I filed separate tickets to add tests for this anyway.
amyblais
added
Changelog/Done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the webapp changes for the new sidebar. These changes add new features such as custom categories and drag and drop, and they also tie the contents of the sidebar to the data provided by the server.
Note that there are outstanding issues with these features, but we've decided that they're small enough that they can be addressed once this is on master. We want to get in the core of this on Monday so that it'll have a week to soak on community-daily before the actual submission deadline.
Since this is coming from a feature branch, a thorough review is less necessary since the individual PRs going into this have already been reviewed.
Ticket Link
https://mattermost.atlassian.net/browse/MM-23730
Related Pull Requests
mattermost/mattermost-redux#1185
mattermost/mattermost#14967