Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

Select Team list container should scale in width based on browser window width #14197 #5833

Merged
merged 5 commits into from
Jul 22, 2020
Merged

Select Team list container should scale in width based on browser window width #14197 #5833

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
59f2358
changed the signup team container max width
sridhar02 Jul 2, 2020
3878fee
added the scroll property in mobile view currently which is overridin…
sridhar02 Jul 2, 2020
68a8c41
reverted signup team container width to 400px and added new class wit…
sridhar02 Jul 15, 2020
3f61fd8
snapshot updated
sridhar02 Jul 15, 2020
8f14f14
remove the unnecessary class name as overflowY is applied on the hove…
sridhar02 Jul 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions components/select_team/__snapshots__/select_team.test.jsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ exports[`components/select_team/SelectTeam should match snapshot 1`] = `
className="col-sm-12"
>
<div
className="signup-team__container"
className="select-team__container signup-team__container"
>
<img
alt="signup team logo"
Expand Down Expand Up @@ -127,7 +127,7 @@ exports[`components/select_team/SelectTeam should match snapshot, on error 1`] =
className="col-sm-12"
>
<div
className="signup-team__container"
className="select-team__container signup-team__container"
>
<img
alt="signup team logo"
Expand Down Expand Up @@ -217,7 +217,7 @@ exports[`components/select_team/SelectTeam should match snapshot, on loading 1`]
className="col-sm-12"
>
<div
className="signup-team__container"
className="select-team__container signup-team__container"
>
<img
alt="signup team logo"
Expand Down Expand Up @@ -298,7 +298,7 @@ exports[`components/select_team/SelectTeam should match snapshot, on no joinable
className="col-sm-12"
>
<div
className="signup-team__container"
className="select-team__container signup-team__container"
>
<img
alt="signup team logo"
Expand Down Expand Up @@ -436,7 +436,7 @@ exports[`components/select_team/SelectTeam should match snapshot, on no joinable
className="col-sm-12"
>
<div
className="signup-team__container"
className="select-team__container signup-team__container"
>
<img
alt="signup team logo"
Expand Down Expand Up @@ -530,7 +530,7 @@ exports[`components/select_team/SelectTeam should match snapshot, on no joinable
className="col-sm-12"
>
<div
className="signup-team__container"
className="select-team__container signup-team__container"
>
<img
alt="signup team logo"
Expand Down
2 changes: 1 addition & 1 deletion components/select_team/select_team.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,7 +336,7 @@ export default class SelectTeam extends React.PureComponent {
{headerButton}
<div className='col-sm-12'>
<div
className={'signup-team__container'}
className={'select-team__container signup-team__container'}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for isolating, I've been thinking we need a unique class to distinguish some of these screens.

>
<img
alt={'signup team logo'}
Expand Down
1 change: 1 addition & 0 deletions sass/responsive/_mobile.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1885,6 +1885,7 @@
.signup-team-all {
max-height: calc(75vh - (118px + 187px));
}

}

@media screen and (max-width: 640px) {
Expand Down
4 changes: 4 additions & 0 deletions sass/routes/_signup.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -482,6 +482,10 @@ body {
}
}

.select-team__container {
max-width: 800px;
}

.signup-team-all {
@include border-radius(2px);
border: 1px solid #dddddd;
Expand Down