This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
MM-26069 Cypress test for MM-T622 which disallow override of username and profile picture #5814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saturninoabril
added
2: Dev Review
Willyfrog
approved these changes
Jun 29, 2020
e2e/cypress/utils/index.js
Outdated
| @@ -56,3 +58,26 @@ export function getMessageMenusPayload({dataSource, options, prefix = Date.now() | |||
| } | |||
|
|
|||
| export const reUrl = /(https?:\/\/[^ ]*)/; | |||
|
|
|||
| export const percentEncoding = { | |||
There was a problem hiding this comment.
not that it is bad, but wouldn't it be more complete if we use encodeURIComponent, that way you don't have to keep up with the list if we start using any other characters.
there is also an encodeURI if you don't care about components of it, but want to treat the whole uri
There was a problem hiding this comment.
Oh right, thanks, I updated using encodeURIComponent since it's all I needed.
josephbaylon
approved these changes
Jun 29, 2020
prapti
approved these changes
Jun 30, 2020
| }); | ||
| }); | ||
|
|
||
| it('MM-T622 Disallow override of username and profile picture', () => { |
prapti
added
4: Reviews Complete
amyblais
added
Changelog/Not Needed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Cypress test for MM-T622 which disallow override of username and profile picture
Ticket Link
JIRA ticket: https://mattermost.atlassian.net/browse/MM-26069
Test case: https://mattermost.atlassian.net/projects/MM?selectedItem=com.atlassian.plugins.atlassian-connect-plugin%3Acom.kanoah.test-manager__main-project-page#!/testCase/MM-T622