This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
[MM-25785] allow pasting tables into edit post, keep caret position #5782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Willyfrog
added
2: Dev Review
ghost
requested review from
amyblais
added
the
CherryPick/Approved
marianunez
reviewed
Jun 25, 2020
Co-authored-by: Maria A Nunez <[email protected]>
marianunez
approved these changes
Jun 25, 2020
Willyfrog
added
the
Setup Cloud Test Server
sudheerDev
approved these changes
Jun 25, 2020
jgilliam17
approved these changes
Jun 26, 2020
There was a problem hiding this comment.
Thank you @Willyfrog
Tested, looks good to merge.
- Verified tables pasting on edit post modal, works the same as in comment text box. Verified caret positioning on edit post as well.
jgilliam17
added
4: Reviews Complete
|
Test server destroyed |
mattermod
added
CherryPick/Done
mattermod
pushed a commit
that referenced
this pull request
Jun 26, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix adding tables into post edits
while working on it, i found it wasn't keeping caretposition when pasting tables from google docs spreadhseets, so I changed that as well
Ticket Link
MM-25785