Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

[MM-26407] Remove beta flag from ldap groups #5780

Merged
merged 1 commit into from
Jun 24, 2020
Merged

[MM-26407] Remove beta flag from ldap groups #5780

merged 1 commit into from
Jun 24, 2020

Conversation

fmunshi
Copy link
Contributor

@fmunshi fmunshi commented Jun 23, 2020

Summary

  • Removes (Beta) from groups in the system console

Ticket Link

Screenshots

Screen Shot 2020-06-23 at 11 38 21 AM

@fmunshi fmunshi added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Jun 23, 2020
@fmunshi fmunshi requested review from sbishel and hahmadia June 23, 2020 15:40
@amyblais amyblais added this to the v5.25.0 milestone Jun 23, 2020
@amyblais amyblais added the CherryPick/Approved Meant for the quality or patch release tracked in the milestone label Jun 23, 2020
@sbishel sbishel requested a review from srkgupta June 23, 2020 17:56
@sbishel sbishel removed the 2: Dev Review Requires review by a core commiter label Jun 23, 2020
srkgupta
srkgupta approved these changes Jun 24, 2020
View reviewed changes
Copy link
Contributor

@srkgupta srkgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and the changes LGTM. Approving the PR.

@srkgupta srkgupta added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Jun 24, 2020
@fmunshi fmunshi merged commit cd9d065 into mattermost:master Jun 24, 2020
@fmunshi fmunshi deleted the MM-26407-remove-beta-ldap branch June 24, 2020 14:40
@mattermost-build mattermost-build mentioned this pull request Jun 24, 2020
Merged
@mattermod mattermod added CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone and removed CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Jun 24, 2020
@amyblais amyblais added the Docs/Needed Requires documentation label Jun 24, 2020
@amyblais amyblais assigned thefactremains and unassigned fmunshi Jun 24, 2020
@amyblais amyblais added the Changelog/Done Required changelog entry has been written label Jun 25, 2020
@faase faase mentioned this pull request Jul 13, 2020
Merged
@amyblais amyblais added Docs/Done Required documentation has been written and removed Docs/Needed Requires documentation labels Jul 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@srkgupta srkgupta srkgupta approved these changes

@sbishel sbishel sbishel approved these changes

@hahmadia hahmadia hahmadia approved these changes

Assignees

@thefactremains thefactremains

Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Done Required changelog entry has been written CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone Docs/Done Required documentation has been written
Projects
None yet
Milestone
v5.25.0
7 participants
@fmunshi @srkgupta @sbishel @hahmadia @mattermod @thefactremains @amyblais