This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
[MM-26426] - Fix translations broken by the webpack require call #5778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jespino
added
2: Dev Review
nevyangelova
added
the
Setup Cloud Test Server
nevyangelova
changed the title
jgilliam17
approved these changes
Jun 23, 2020
There was a problem hiding this comment.
Thank you @jespino
Tested, looks good to merge.
- Verified user can change language in account settings > display > language.
jgilliam17
added
QA Review Done
and removed
3: QA Review
|
Test server destroyed |
mgdelacroix
approved these changes
Jun 24, 2020
mgdelacroix
added
4: Reviews Complete
amyblais
added
Changelog/Not Needed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I think this was broken because we updated the dependencies. The
requirecalls were getting the object including the default export insted of using
directly that default value as the imported value. Now using import is working
fine.
Ticket Link
MM-26426