Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

[MM-25804] fix removing dm from localstorage #5747

Merged
merged 7 commits into from
Jun 23, 2020
Merged

[MM-25804] fix removing dm from localstorage #5747

merged 7 commits into from
Jun 23, 2020

Conversation

Willyfrog
Copy link
Contributor

Summary

when using the old sidebar, visiting a new channel and removing the previous dm was deleting the last visited instead of the previous one from the local storage.

Not in the original description but found while doing this:

  • if using the new one, the function was not even being called.
  • if removing a dm,but it was on a different team, moving to that team and reloading base url could make it reappear

Ticket Link

MM-25804

@Willyfrog Willyfrog added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Jun 18, 2020
@Willyfrog Willyfrog changed the title Mm 25804 fix removing dm from localstorage [MM-25804] fix removing dm from localstorage Jun 18, 2020
@Willyfrog
Copy link
Contributor Author

/update-branch

@jgilliam17 jgilliam17 added the Setup Cloud Test Server Setup a test server using Mattermost Cloud label Jun 23, 2020
@mm-cloud-bot mm-cloud-bot removed the Setup Cloud Test Server Setup a test server using Mattermost Cloud label Jun 23, 2020
@stylianosrigas stylianosrigas added the Setup Cloud Test Server Setup a test server using Mattermost Cloud label Jun 23, 2020
jgilliam17
jgilliam17 approved these changes Jun 23, 2020
View reviewed changes
Copy link
Contributor

@jgilliam17 jgilliam17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Willyfrog
Tested, looks good to merge.

  • Verified user is returned to the last DM they were viewing, after reloading to root URL.

@jgilliam17 jgilliam17 added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester Setup Cloud Test Server Setup a test server using Mattermost Cloud labels Jun 23, 2020
@mm-cloud-bot
Copy link

Test server destroyed

@Willyfrog Willyfrog merged commit 2f8c7bc into mattermost:master Jun 23, 2020
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Jul 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hmhealey hmhealey hmhealey approved these changes

@nevyangelova nevyangelova nevyangelova approved these changes

@jgilliam17 jgilliam17 jgilliam17 approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation
Projects
None yet
Milestone
No milestone
8 participants
@Willyfrog @mm-cloud-bot @hmhealey @nevyangelova @jgilliam17 @stylianosrigas @amyblais @mattermod