Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

MM-26071 Cypress/E2E: Upgrade Cypress to 4.8.0 and other dependencies to latest #5725

Merged
merged 4 commits into from
Jun 17, 2020

Conversation

saturninoabril
Copy link
Member

@saturninoabril saturninoabril commented Jun 15, 2020

Summary

Upgrade Cypress to 4.8.0 and other dependencies to latest

Ticket

Jira ticket - https://mattermost.atlassian.net/browse/MM-26071

Test results on CI:

@saturninoabril saturninoabril added the 3: QA Review Requires review by a QA tester label Jun 15, 2020
Copy link
Contributor

@josephbaylon josephbaylon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just minor cleanup on .only

@saturninoabril saturninoabril changed the title Cypress/E2E: Upgrade Cypress to 4.8.0 and other dependencies to latest MM-26071 Cypress/E2E: Upgrade Cypress to 4.8.0 and other dependencies to latest Jun 15, 2020
Copy link
Contributor

@prapti prapti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran a few tests, and all passed 🎉
Approving.

Copy link
Contributor

@srkgupta srkgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM. Thanks @saturninoabril

@srkgupta
Copy link
Contributor

@saturninoabril
Can you please fix the merge conflict now that the other PR was merged.

@saturninoabril saturninoabril added 4: Reviews Complete All reviewers have approved the pull request AutoMerge used by Mattermod to merge PR automatically and removed 3: QA Review Requires review by a QA tester labels Jun 17, 2020
@mattermod
Copy link
Contributor

Will try to auto merge this PR once all tests and checks are passing. This might take up to an hour.

1 similar comment
@mattermod
Copy link
Contributor

Will try to auto merge this PR once all tests and checks are passing. This might take up to an hour.

@saturninoabril saturninoabril removed the AutoMerge used by Mattermod to merge PR automatically label Jun 17, 2020
@saturninoabril saturninoabril merged commit 438c0c9 into mattermost:master Jun 17, 2020
@saturninoabril saturninoabril deleted the upgrade-cypress-480 branch June 17, 2020 11:34
saturninoabril added a commit to saturninoabril/mattermost-webapp that referenced this pull request Jun 17, 2020
… to latest (mattermost#5725)

* upgrade Cypress to 4.8.0 and other dependencies to latest

* remove .only and use timeout constant

Co-authored-by: Saturnino Abril <[email protected]>
saturninoabril added a commit to saturninoabril/mattermost-webapp that referenced this pull request Jun 17, 2020
… to latest (mattermost#5725)

* upgrade Cypress to 4.8.0 and other dependencies to latest

* remove .only and use timeout constant

Co-authored-by: Saturnino Abril <[email protected]>
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Jun 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants