Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

[MM-25952] Fix license banner hiding revoke sessions #5710

Merged
merged 1 commit into from
Jun 15, 2020
Merged

[MM-25952] Fix license banner hiding revoke sessions #5710

merged 1 commit into from
Jun 15, 2020

Conversation

fmunshi
Copy link
Contributor

@fmunshi fmunshi commented Jun 11, 2020

Summary

  • Decreases filtered user list height when announcement banner is present
  • Also reduces the filtered user list height by a bit when the banner is not present to prevent a scrollbar from appearing on the side

Ticket Link

Screenshots

Before:
Screen Shot 2020-06-11 at 3 05 45 PM

After:

Screen Shot 2020-06-11 at 3 05 21 PM

@fmunshi fmunshi added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Jun 11, 2020
@fmunshi fmunshi requested review from reflog and Willyfrog June 11, 2020 19:09
@reflog reflog removed the 2: Dev Review Requires review by a core commiter label Jun 14, 2020
@fmunshi fmunshi requested a review from srkgupta June 14, 2020 18:47
@srkgupta srkgupta added the Setup Cloud Test Server Setup a test server using Mattermost Cloud label Jun 15, 2020
srkgupta
srkgupta approved these changes Jun 15, 2020
View reviewed changes
Copy link
Contributor

@srkgupta srkgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and the issue is now working fine. Approving the PR.

@srkgupta srkgupta added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester Setup Cloud Test Server Setup a test server using Mattermost Cloud labels Jun 15, 2020
@mm-cloud-bot
Copy link

Test server destroyed

@fmunshi fmunshi added this to the v5.25.0 milestone Jun 15, 2020
@fmunshi fmunshi merged commit aca4c89 into mattermost:master Jun 15, 2020
@fmunshi fmunshi deleted the MM-25952-Fix-license-banner-hiding-revoke-sessions branch June 15, 2020 19:24
@fmunshi fmunshi self-assigned this Jun 15, 2020
saturninoabril pushed a commit to saturninoabril/mattermost-webapp that referenced this pull request Jun 17, 2020
@fmunshi
MM-25952 Fix license banner hiding revoke sessions and scrollbar appe…
5bd3f87 
…aring on sys console users page (mattermost#5710)
saturninoabril pushed a commit to saturninoabril/mattermost-webapp that referenced this pull request Jun 17, 2020
@fmunshi
MM-25952 Fix license banner hiding revoke sessions and scrollbar appe…
9e10d5c 
…aring on sys console users page (mattermost#5710)
@amyblais amyblais added the CherryPick/Approved Meant for the quality or patch release tracked in the milestone label Jun 18, 2020
fmunshi added a commit to fmunshi/mattermost-webapp that referenced this pull request Jun 18, 2020
@fmunshi
MM-25952 Fix license banner hiding revoke sessions and scrollbar appe…
d41494b 
…aring on sys console users page (mattermost#5710)
@fmunshi fmunshi mentioned this pull request Jun 18, 2020
Merged
@fmunshi fmunshi added CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone and removed CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Jun 18, 2020
fmunshi added a commit that referenced this pull request Jun 18, 2020
@fmunshi
MM-25952 Fix license banner hiding revoke sessions and scrollbar appe…
144ede1 
…aring on sys console users page (#5710) (#5759)
@amyblais amyblais added Changelog/Done Required changelog entry has been written Docs/Not Needed Does not require documentation labels Jun 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@reflog reflog reflog approved these changes

@srkgupta srkgupta srkgupta approved these changes

@Willyfrog Willyfrog Willyfrog approved these changes

Assignees

@fmunshi fmunshi

Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Done Required changelog entry has been written CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone Docs/Not Needed Does not require documentation
Projects
None yet
Milestone
v5.25.0
6 participants
@fmunshi @mm-cloud-bot @reflog @srkgupta @Willyfrog @amyblais