Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

[MM-25921] Modify admin console index tests to ignore order check in spanish #5695

Merged
merged 1 commit into from
Jun 9, 2020
Merged

[MM-25921] Modify admin console index tests to ignore order check in spanish #5695

merged 1 commit into from
Jun 9, 2020

Conversation

fmunshi
Copy link
Contributor

@fmunshi fmunshi commented Jun 9, 2020

Summary

  • These tests should not check the order of search results in languages other than english since they can change if the community updates translations as seen here translations PR 20200608 #5688

Ticket Link

@fmunshi fmunshi added 2: Dev Review Requires review by a core commiter CherryPick/Candidate A candidate for a quality or patch release, but not yet approved labels Jun 9, 2020
@fmunshi fmunshi added this to the v5.24.0 milestone Jun 9, 2020
@fmunshi fmunshi requested review from lieut-data, hahmadia and bradjcoughlin and removed request for hahmadia June 9, 2020 15:30
@fmunshi
Copy link
Contributor Author

fmunshi commented Jun 9, 2020

@bradjcoughlin I noticed you touched this file a bunch - does this change make sense to prevent issues like the one seen here #5688?

@fmunshi fmunshi requested a review from enahum June 9, 2020 16:37
@fmunshi
Copy link
Contributor Author

fmunshi commented Jun 9, 2020

Merging without QA Review since this only modifies test files

@fmunshi fmunshi added CherryPick/Approved Meant for the quality or patch release tracked in the milestone and removed CherryPick/Candidate A candidate for a quality or patch release, but not yet approved labels Jun 9, 2020
@fmunshi fmunshi removed the request for review from lieut-data June 9, 2020 16:39
@fmunshi fmunshi merged commit 0d2187e into mattermost:master Jun 9, 2020
@mattermost-build mattermost-build mentioned this pull request Jun 9, 2020
Merged
@mattermod mattermod added CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone and removed CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Jun 9, 2020
@fmunshi fmunshi deleted the MM-25921 branch June 9, 2020 16:45
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation and removed 2: Dev Review Requires review by a core commiter labels Jun 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@enahum enahum enahum approved these changes

@bradjcoughlin bradjcoughlin Awaiting requested review from bradjcoughlin

Assignees
No one assigned
Labels
Changelog/Not Needed Does not require a changelog entry CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone Docs/Not Needed Does not require documentation
Projects
None yet
Milestone
v5.24.0
Development

Successfully merging this pull request may close these issues.
4 participants
@fmunshi @enahum @mattermod @amyblais