-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Conversation
@prapti Looks good to me. Just few requests:
|
Thanks for a quick check @saturninoabril! I'll add make those changes and update the PR description. Meanwhile, I've changed it to a WIP PR for now as I'm running some tests from the smoke group to gather some data upfront. I'll update the PR soon. And thanks for reminding that the marketplace tests aren't 100%. Will need to remove them now until fixed. |
// Stage: @prod @smoke | ||
// Group: @accessibility | ||
// Group: @accessibility @smoke |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm confused how do you plan to run this.
If @smoke
will be on "Group" metadata which I think makes sense, then the @smoke
tags on "Stage" can be removed. With that, it could run as node run_tests.js --stage='@prod' --group'@smoke'
// Stage: @prod @smoke | |
// Group: @accessibility | |
// Group: @accessibility @smoke | |
// Stage: @prod | |
// Group: @accessibility @smoke |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I just read your updated description with node run_tests.js --stage='@smoke' --group='@smoke'
. However, passing @smoke
on both args feels redundant to me.
Removed '@smoke' tag from all other specs not intended for smoke tests. Now that the tag has been added as "Group", the tests can be run simply with |
…nfusion in running tests with that tag inside the 'stage' suite
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks @prapti!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Approving the PR. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Adding
@smoke
tags to 7 pre-existing E2E tests for PR smoke test, which takes roughly 5 minutes to run.This PR covers smoke tests in the following E2E test files and were selected based on preliminary review of the Smoke Tests doc.
create_a_team_spec
accessibility_sidebar_spec
add_users_to_channel_spec
message_spec
search_user_post
demoted_user_spec
(changed this from cluster_spec to add a more consistently passing test)tutorial_navigation_and_links_spec
To run the tests, please run the following:
node run_tests.js --group='@smoke'