MM-25261: Adds archived channels to admin console channel list view. #5635

mkraft · 2020-06-01T19:15:17Z

Summary

Displays archived channels in the channels list view. Add ability to archive and unarchive channels from their details view.

Also this PR reorders the channel moderation widget among the other widgets in the channel details view.

Ticket Link

Related Pull Requests

Has server changes: MM-25261: Add 'include_deleted' parameter to get all channels API req… mattermost#14721
Has redux changes: MM-25261: Adds the 'include_deleted' parameter to the get and search … mattermost-redux#1168

Screenshots

michaelgamble

looks great :)

mm-cloud-bot · 2020-06-04T15:57:29Z

Test server destroyed

fmunshi · 2020-06-10T01:03:53Z

components/admin_console/team_channel_settings/channel/details/channel_profile.tsx

@@ -26,7 +44,7 @@ export const ChannelProfile: React.SFC<ChannelProfileProps> = (props: ChannelPro
 subtitleId={t('admin.channel_settings.channel_detail.profileDescription')}
 subtitleDefault='Summary of the channel, including the channel name.'
 >
- <div className='group-teams-and-channels'>
+ <div className='group-teams-and-channels AdminChannelDetails'>


do we need to keep the old class? Would be nice to get rid of it / update e2e tests to use the new class if its not being used

I'm not sure how to deal with this. My thinking was to use the new naming convention, but there are still a bunch of styles tied to .group-teams-and-channels. What do you think? We could:

a) replace AdminChannelDetails with group-teams-and-channels and tie the new styles to it instead
c) update group-teams-and-channels to be GroupTeamsAndChannels and then all of the associated states like group-teams-and-channels--body, etc, this does mean updating a bunch of things including tests, not insurmountable just noting it
d) new stuff goes under AdminChannelDetails (ie leave it as-is in the PR)

Thoughts? Other ideas?

fmunshi

Looks good to me other than one minor comment

fmunshi · 2020-06-10T01:06:48Z

Also looks like you've got some conflicts to take care of @mkraft

fmunshi · 2020-06-10T01:07:31Z

Paging @catalintomai for review

…chived-channels

…hived status.

srkgupta

Hi @mkraft
I tested the PR and overall it looks good. Found couple of issues which I have raised them here:

MM-26176: Discard Changes confirmation is not displayed when user archives/unarchives a channel in Channel Configurations page & clicks anywhere else
MM-26177 - Team Member is allowed to view the archived channels even when the option is restricted in System Console

…chived-channels

srkgupta

Tested the PR along with it's dependent PRs and the feature is working fine as expected. There is a known limitation currently which will be handled in this story https://mattermost.atlassian.net/browse/MM-26217

Apart from this, the rest of the functionalities were working fine. Approving the PR.

…chived-channels

thefactremains · 2020-07-17T18:11:52Z

adding a note to remind myself to update this docs page before release: https://docs.mattermost.com/help/getting-started/organizing-conversations.html#archiving-a-channel

Docs for: mattermost/mattermost-webapp#5635

Docs for: mattermost/mattermost-webapp#5635. Adds a change to docs that are already submitted in a PR but shouldn't cause any conflicts.

* Update team-channel-management.rst Docs for: mattermost/mattermost-webapp#5635 * Update team-channel-management.rst Added filters to channel management section. Fixed incorrect use of "team" in channel section. Documents: mattermost/mattermost-webapp#5899. Co-authored-by: Amy Blais <[email protected]>

* Update conf.py (#3755) * Update open-source-components.rst (#3793) * Update important-upgrade-notes.rst (#3771) * Update important-upgrade-notes.rst * Update important-upgrade-notes.rst * Update important-upgrade-notes.rst * Update important-upgrade-notes.rst * Update important-upgrade-notes.rst * Documentation for "ask the community" feature (#3804) * Update config-settings.rst * Update source/administration/config-settings.rst Co-authored-by: Justine Geffen <[email protected]> * Update source/administration/config-settings.rst Co-authored-by: Justine Geffen <[email protected]> * Make modifications (add link URL, remove mention of the Main Menu) * Update source/administration/config-settings.rst Co-authored-by: Jason Blais <[email protected]> * Add default value Co-authored-by: Justine Geffen <[email protected]> * ES-v5.26-docs (#3812) * Update formatting-text.rst * prefetching and sidebar updates for v5.26 * Channel sidebar phase 2 updates * Add files via upload * Update source/administration/config-settings.rst Co-authored-by: Amy Blais <[email protected]> * Update config-settings.rst * Update formatting-text.rst Co-authored-by: Amy Blais <[email protected]> * added telemetry for Team & Channel management (#3818) * added telemetry for Team & Channel management * Update source/administration/telemetry.rst * Update source/administration/telemetry.rst * Update source/administration/telemetry.rst Co-authored-by: Justine Geffen <[email protected]> * added telemetry for gossip encryption (#3819) * Update Global Relay config-settings.rst (#3820) * Update config-settings.rst Changes for: mattermost/mattermost#14994 * Update source/administration/config-settings.rst Co-authored-by: Ibrahim Serdar Acikgoz <[email protected]> * Apply suggestions from code review Co-authored-by: Justine Geffen <[email protected]> * Update config-settings.rst Fixed example formatting. Co-authored-by: Ibrahim Serdar Acikgoz <[email protected]> * Update elasticsearch.rst (#3826) Update for: mattermost/mattermost#14463 * Update team-channel-management.rst * Advanced Logging (#3836) * Advanced Logging Added section to cover Advanced Logging Options (E20 only). Changed "Logging" to "Standard Logging" * Update config-settings.rst Review of additional content and general review of page to fix heading lengths and some typos. * Fixing broken links Co-authored-by: Justine Geffen <[email protected]> Co-authored-by: Amy Blais <[email protected]> * added member filters (#3835) added member filters - mattermost/mattermost-webapp#5882 * v5.26 Changelog (#3757) * Update changelog.md * Update changelog.md * Update changelog.md * Update changelog.md * Update changelog.md * Update changelog.md * Update changelog.md * Update changelog.md * Update changelog.md * Update changelog.md * Update changelog.md * Update changelog.md * Update changelog.md * Update changelog.md * Update changelog.md * Update changelog.md * Update changelog.md * Update changelog.md * Update changelog.md * Update changelog.md * Update changelog.md * Update changelog.md * Update changelog.md * Update changelog.md * Update changelog.md * Update changelog.md * Update changelog.md * Update changelog.md * Update changelog.md * Update changelog.md * Update changelog.md * Update mentioning-teammates.rst (#3821) Added mobile support for group mentions. * Update organizing-conversations.rst (#3832) Docs for: mattermost/mattermost-webapp#5635. Adds a change to docs that are already submitted in a PR but shouldn't cause any conflicts. * Update team-channel-management.rst (#3830) * Update team-channel-management.rst Docs for: mattermost/mattermost-webapp#5635 * Update team-channel-management.rst Added filters to channel management section. Fixed incorrect use of "team" in channel section. Documents: mattermost/mattermost-webapp#5899. Co-authored-by: Amy Blais <[email protected]> Co-authored-by: Jason Blais <[email protected]> Co-authored-by: Justine Geffen <[email protected]> Co-authored-by: Eric Sethna <[email protected]> Co-authored-by: Dennis Kittrell <[email protected]> Co-authored-by: Ibrahim Serdar Acikgoz <[email protected]>

mkraft added the Work in Progress Not yet ready for review label Jun 1, 2020

MM-25261: Adds archived channels to admin console channel list view.

6f1bd81

mkraft added 1: UX Review Requires review by a UX Designer 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester and removed Work in Progress Not yet ready for review labels Jun 2, 2020

mkraft requested a review from michaelgamble June 2, 2020 20:39

mkraft added 8 commits June 2, 2020 16:52

MM-25261: Points to redux commit for UX and QA reviews.

8f899ee

MM-25261: Fixes some missing params in tests.

fed9ba3

MM-25266: Reorders the moderation widget in channel details.

c1f72d6

MM-25266: Updates snapshot for recordered widget.

d38b12a

MM-25261: Test fix.

7393c67

MM-25261: Styling tweaks.

7f0f9b0

MM-25261: Updates snapshot.

7878565

MM-25261: Updates to unarchive svg icon.

db469f9

mkraft requested review from fmunshi and catalintomai June 3, 2020 19:25

michaelgamble approved these changes Jun 3, 2020

View reviewed changes

mkraft added Setup Cloud Test Server Setup a test server using Mattermost Cloud and removed Setup Cloud Test Server Setup a test server using Mattermost Cloud labels Jun 4, 2020

fmunshi reviewed Jun 10, 2020

View reviewed changes

fmunshi approved these changes Jun 10, 2020

View reviewed changes

fmunshi removed the 1: UX Review Requires review by a UX Designer label Jun 10, 2020

Merge remote-tracking branch 'origin/master' into MM-25261_console-ar…

fd0cd8d

…chived-channels

mkraft added this to the v5.26 milestone Jun 10, 2020

catalintomai approved these changes Jun 12, 2020

View reviewed changes

mkraft requested a review from srkgupta June 12, 2020 22:00

mkraft added 2 commits June 15, 2020 12:09

Merge remote-tracking branch 'origin/master' into MM-25261_console-ar…

bc3a3ef

…chived-channels

MM-25261: Renames state variable to differentiate local vs server arc…

b003509

…hived status.

srkgupta suggested changes Jun 16, 2020

View reviewed changes

This was referenced Jun 17, 2020

MM-25261: Add 'include_deleted' parameter to get all channels API req… mattermost/mattermost#14721

Merged

MM-25261: Adds the 'include_deleted' parameter to the get and search … mattermost/mattermost-redux#1168

Merged

mkraft added 2 commits June 17, 2020 08:52

Merge remote-tracking branch 'origin/master' into MM-25261_console-ar…

5ce1e9a

…chived-channels

MM-25261: Confirms save when archive button toggled.

53efa24

srkgupta approved these changes Jun 18, 2020

View reviewed changes

srkgupta added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Jun 18, 2020

mkraft added 4 commits June 18, 2020 12:23

Merge remote-tracking branch 'origin/master' into MM-25261_console-ar…

eddbae8

…chived-channels

Merge remote-tracking branch 'origin/master' into MM-25261_console-ar…

9b819dd

…chived-channels

MM-25261: Fixes merge conflict resolution error.

f5c5fb4

MM-25261: Updates snapshot.

69c0061

mkraft merged commit 223d2f9 into mattermost:master Jun 19, 2020

mkraft deleted the MM-25261_console-archived-channels branch June 19, 2020 20:53

amyblais added Changelog/Done Required changelog entry has been written Docs/Needed Requires documentation labels Jul 17, 2020

amyblais assigned thefactremains Jul 20, 2020

justinegeffen added a commit to mattermost/docs that referenced this pull request Aug 12, 2020

Update team-channel-management.rst

22fdae6

Docs for: mattermost/mattermost-webapp#5635

justinegeffen added a commit to mattermost/docs that referenced this pull request Aug 12, 2020

Update organizing-conversations.rst

bb7b150

Docs for: mattermost/mattermost-webapp#5635. Adds a change to docs that are already submitted in a PR but shouldn't cause any conflicts.

justinegeffen mentioned this pull request Aug 12, 2020

Update organizing-conversations.rst mattermost/docs#3832

Merged

amyblais added Docs/Done Required documentation has been written and removed Docs/Needed Requires documentation labels Aug 12, 2020

amyblais pushed a commit to mattermost/docs that referenced this pull request Aug 13, 2020

Update organizing-conversations.rst (#3832)

3368f3c

Docs for: mattermost/mattermost-webapp#5635. Adds a change to docs that are already submitted in a PR but shouldn't cause any conflicts.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MM-25261: Adds archived channels to admin console channel list view. #5635

MM-25261: Adds archived channels to admin console channel list view. #5635

mkraft commented Jun 1, 2020 •

edited

Loading

michaelgamble left a comment

mm-cloud-bot commented Jun 4, 2020

fmunshi Jun 10, 2020 •

edited

Loading

mkraft Jun 10, 2020

fmunshi left a comment

fmunshi commented Jun 10, 2020

fmunshi commented Jun 10, 2020

srkgupta left a comment

srkgupta left a comment

thefactremains commented Jul 17, 2020

MM-25261: Adds archived channels to admin console channel list view. #5635

MM-25261: Adds archived channels to admin console channel list view. #5635

Conversation

mkraft commented Jun 1, 2020 • edited Loading

Summary

Ticket Link

Related Pull Requests

Screenshots

michaelgamble left a comment

Choose a reason for hiding this comment

mm-cloud-bot commented Jun 4, 2020

fmunshi Jun 10, 2020 • edited Loading

Choose a reason for hiding this comment

mkraft Jun 10, 2020

Choose a reason for hiding this comment

fmunshi left a comment

Choose a reason for hiding this comment

fmunshi commented Jun 10, 2020

fmunshi commented Jun 10, 2020

srkgupta left a comment

Choose a reason for hiding this comment

srkgupta left a comment

Choose a reason for hiding this comment

thefactremains commented Jul 17, 2020

mkraft commented Jun 1, 2020 •

edited

Loading

fmunshi Jun 10, 2020 •

edited

Loading