Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

[MM-25561] Added extra padding on admin console sidebar when announcement bar is visible #5629

Merged
merged 1 commit into from
Jun 2, 2020
Merged

[MM-25561] Added extra padding on admin console sidebar when announcement bar is visible #5629

merged 1 commit into from
Jun 2, 2020

Conversation

devinbinnie
Copy link
Member

Summary

When the announcement bar is visible in the System Console, the sidebar is pushed down by 32px, thus cutting off the bottom-most sidebar item.

This PR adds 32px of padding to the bottom of the sidebar so that nothing can be cutoff.

Ticket Link

https://mattermost.atlassian.net/browse/MM-25661

@devinbinnie devinbinnie added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester CherryPick/Approved Meant for the quality or patch release tracked in the milestone 1: UX Review Requires review by a UX Designer labels May 30, 2020
@devinbinnie devinbinnie added this to the v5.24.0 milestone May 30, 2020
@devinbinnie devinbinnie removed the 1: UX Review Requires review by a UX Designer label Jun 1, 2020
@mkraft mkraft removed the 2: Dev Review Requires review by a core commiter label Jun 1, 2020
@mkraft mkraft requested a review from jgilliam17 June 1, 2020 20:45
@jgilliam17 jgilliam17 added the Setup Cloud Test Server Setup a test server using Mattermost Cloud label Jun 2, 2020
jgilliam17
jgilliam17 approved these changes Jun 2, 2020
View reviewed changes
Copy link
Contributor

@jgilliam17 jgilliam17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @devinbinnie
Tested, looks good to merge.

  • Verified when banner is visible in the System Console, all items are also visible on the left side, no cut-off items on the bottom of the list.

@jgilliam17 jgilliam17 added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester Setup Cloud Test Server Setup a test server using Mattermost Cloud labels Jun 2, 2020
@mm-cloud-bot
Copy link

Test server destroyed

@devinbinnie devinbinnie merged commit d38a4ae into mattermost:master Jun 2, 2020
@mattermost-build mattermost-build mentioned this pull request Jun 2, 2020
Merged
@mattermod mattermod added CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone and removed CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Jun 2, 2020
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Jun 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lieut-data lieut-data lieut-data approved these changes

@mkraft mkraft mkraft approved these changes

@asaadmahmood asaadmahmood asaadmahmood approved these changes

@jgilliam17 jgilliam17 jgilliam17 approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone Docs/Not Needed Does not require documentation
Projects
None yet
Milestone
v5.24.0
Development

Successfully merging this pull request may close these issues.
8 participants
@devinbinnie @mm-cloud-bot @lieut-data @mkraft @asaadmahmood @jgilliam17 @mattermod @amyblais