This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
[MM-25373] [MM-25374] [MM-25106] - Fix functionality bugs in search hint popover #5610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 27, 2020 19:19
devinbinnie
approved these changes
May 27, 2020
sudheerDev
approved these changes
May 28, 2020
components/search_bar/search_bar.jsx
Outdated
| visibleSearchHintOptions = searchHintOptions.filter((option) => { | ||
| return new RegExp(pretext, 'ig').test(option.searchTerm) && option.searchTerm.toLowerCase() !== pretext.toLowerCase(); | ||
| }); | ||
| } catch (err) { |
There was a problem hiding this comment.
is err needed? Didn't linter complain?
There was a problem hiding this comment.
Whoops. Will remove
|
@nevyangelova |
|
@jgilliam17 fixed |
609c41f
to
d40d757
Compare
|
Thank you @nevyangelova
|
|
@jgilliam17 thanks, Ogi found this issue in #5485 and its fixed there. Sorry for the mash-up. |
|
@nevyangelova
|
2669ca5
to
9fdcb37
Compare
jgilliam17
approved these changes
Jun 2, 2020
There was a problem hiding this comment.
Thank you @nevyangelova
- Verified search hint popover does not display over autocomplete list
- Verified search inputs are not added inadvertently while hovering and hitting Enter
- Verified search hint popover was present when user focused on the search field.
- Verified auto-sorting as user types is working again and dash size has been increased for visibility
Issues that were raised with at-mentions and when hint list is part of the RHS will be tested after merge as it's addressed in the different PR.
|
Test server destroyed |
mattermod
pushed a commit
that referenced
this pull request
Jun 2, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses functionality bugs related to the search hint popover. I have tested thoroughly but let me know if you find anything else.
Ticket Link
https://mattermost.atlassian.net/browse/MM-25373
https://mattermost.atlassian.net/browse/MM-25374
https://mattermost.atlassian.net/browse/MM-25106#### Related Pull Requests