This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
MM-25492, MM-25485, MM-25483 - Autocomplete ui fixes #5593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asaadmahmood
added
2: Dev Review
|
@lindy65 This may not fix your issue of the bottom border not showing as that's an edge case for a very small screen height. |
marianunez
approved these changes
May 27, 2020
lindy65
added
the
Setup Cloud Test Server
lindy65
approved these changes
May 27, 2020
There was a problem hiding this comment.
Thanks @asaadmahmood - issues listed in all 3 tickets are fixed. 👍
As you mentioned above, the issue of the bottom border is not fixed for me in my normal view but, if I make the text size smaller on my screen, then I am able to see the bottom border.
lindy65
added
QA Review Done
and removed
3: QA Review
|
Test server destroyed |
cpoile
approved these changes
May 27, 2020
cpoile
added
4: Reviews Complete
mattermod
added
CherryPick/Done
mattermod
pushed a commit
that referenced
this pull request
May 27, 2020
amyblais
added
Changelog/Not Needed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Autocomplete ui fixes
MM-25492 - Aligning autocomplete to the left
MM-25485 - Updating icon sizes in switcher modal
MM-25483 - Updating icon sizes in popover
Ticket Link
https://mattermost.atlassian.net/browse/MM-25492
https://mattermost.atlassian.net/browse/MM-25485
https://mattermost.atlassian.net/browse/MM-25483
Screenshots