This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
[MM-24929] Force red background on mobile view header mention badge #5560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinbinnie
added
2: Dev Review
deanwhillier
approved these changes
May 25, 2020
jgilliam17
added
the
Setup Cloud Test Server
jgilliam17
approved these changes
May 26, 2020
There was a problem hiding this comment.
Thank you @devinbinnie
Tested, looks good to merge
- Verified red background is present on mobile view header mention badge
jgilliam17
added
QA Review Done
and removed
3: QA Review
|
Test server destroyed |
devinbinnie
added
4: Reviews Complete
mattermod
added
CherryPick/Done
devinbinnie
added a commit
that referenced
this pull request
May 26, 2020
* Force red background on mobile view header mention badge * Rework to use better CSS Co-authored-by: Devin Binnie <[email protected]>
amyblais
added
Changelog/Not Needed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
At some point during v5.24 development, the CSS style sheet stopped using the
background-colorfor thebadge-notifyclass on the mobile view header mention badge, and started using thebackgroundprovided by thebadgeclass.This PR changes the order of the classes in the CSS file such that the
.badge-notifyclass has a higher specificity that will override thebackground-colorof the defaultbadgeclass.Ticket Link
https://mattermost.atlassian.net/browse/MM-24929