Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

MM-22304 Enable SAML OKTA test in CircleCI/Cypress #5508

Merged
merged 3 commits into from
May 21, 2020
Merged

MM-22304 Enable SAML OKTA test in CircleCI/Cypress #5508

merged 3 commits into from
May 21, 2020

Conversation

saturninoabril
Copy link
Member

@saturninoabril saturninoabril commented May 18, 2020 •
edited
Loading

Summary

  • Enable SAML OKTA test in CircleCI/Cypress
  • Did minor fix on spec file
  • Add API commands to upload certificates and key

export CYPRESS_chromeWebSecurity=false requires to bypass built-in web security when redirecting to other URL like IDP URL. Instruction added to corresponding private repo.

Ticket Link

Jira ticket: https://mattermost.atlassian.net/browse/MM-22304

@saturninoabril saturninoabril added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels May 18, 2020
@saturninoabril saturninoabril mentioned this pull request May 18, 2020
Closed
srkgupta
srkgupta approved these changes May 18, 2020
View reviewed changes
Copy link
Contributor

@srkgupta srkgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran the tests and all of them passed. Approving the PR. Thanks @saturninoabril

josephbaylon
josephbaylon approved these changes May 18, 2020
View reviewed changes
Copy link
Contributor

@josephbaylon josephbaylon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@metanerd
Copy link
Contributor

/update-branch

@saturninoabril saturninoabril mentioned this pull request May 19, 2020
Merged
catalintomai
catalintomai approved these changes May 20, 2020
View reviewed changes
Copy link
Contributor

@catalintomai catalintomai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code gets better and better = )

@saturninoabril saturninoabril added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels May 21, 2020
@saturninoabril saturninoabril merged commit 31d9a13 into master May 21, 2020
@saturninoabril saturninoabril deleted the MM-22304-cypress_circleci_enable_saml branch May 21, 2020 05:03
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels May 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@josephbaylon josephbaylon josephbaylon approved these changes

@srkgupta srkgupta srkgupta approved these changes

@catalintomai catalintomai catalintomai approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@saturninoabril @metanerd @josephbaylon @srkgupta @catalintomai @amyblais @mattermod