Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

[MM-21494] Slash Command Autocomplete #5499

Merged
merged 4 commits into from
May 21, 2020
Merged

[MM-21494] Slash Command Autocomplete #5499

merged 4 commits into from
May 21, 2020

Conversation

iomodo
Copy link
Contributor

@iomodo iomodo commented May 14, 2020

Summary

This PR implements slash command autocomplete.

Ticket Link

See fixed ticket links in the server PR.

Related Pull Requests

Screenshots

autocomplete

@iomodo @mattermod @hanzei
[MM-21494] autocomplete suggestions (#5289)
2dde2e0 
* Add support of autocomplete suggestions

* Revert changes for mobile

* Remove unused variable

* [MM-24767] autocomplete icons (#5450)

* Add support for icons

* fix test

* Update styling for autocomplete icons

* Fix at mention provider supporting command autocomplete

* Fix tests

* Fix indented code

Co-authored-by: mattermod <[email protected]>
Co-authored-by: Ben Schumacher <[email protected]>
@iomodo iomodo added 1: UX Review Requires review by a UX Designer 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels May 14, 2020
@iomodo iomodo mentioned this pull request May 14, 2020
Merged
@iomodo iomodo removed the 1: UX Review Requires review by a UX Designer label May 14, 2020
@metanerd
Copy link
Contributor

/update-branch

@levb levb added this to Submitted in Integrations Team via automation May 20, 2020
@DHaussermann
Copy link

/update-branch

@DHaussermann
Copy link

DHaussermann commented May 20, 2020 •
edited
Loading

Regression tested this for backwards compatibility

  • Ran through release testing of all system slash commands
  • Tested main input and RHS
  • Regression tested other auto-completes such such as channel and @ mentions as a precaution
  • Regression tested a couple plugins for backwards compatibility. No issues found passing parameters (string and bool)
  • Regression tested a custom slash command for backwards compatibility
  • Confirmed with Shota web traffic on auto-complete looks as expected
  • Confirmed with Shota that parsing the commands should not cause any noticeable performance deterioration
  • Briefly tested existing commands on mobile
    LGTM! Please merge.

@DHaussermann DHaussermann added QA Review Done and removed 3: QA Review Requires review by a QA tester labels May 20, 2020
@amyblais amyblais added CherryPick/Approved Meant for the quality or patch release tracked in the milestone and removed 2: Dev Review Requires review by a core commiter labels May 20, 2020
@amyblais amyblais added this to the v5.24.0 milestone May 20, 2020
@iomodo iomodo merged commit 31ef048 into master May 21, 2020
Integrations Team automation moved this from Submitted to Done May 21, 2020
@iomodo iomodo deleted the MM-20684-Slash-Command-Autocomplete branch May 21, 2020 10:33
@mattermost-build mattermost-build mentioned this pull request May 21, 2020
Merged
@mattermod mattermod added the CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone label May 21, 2020
@mattermod mattermod removed the CherryPick/Approved Meant for the quality or patch release tracked in the milestone label May 21, 2020
@amyblais amyblais added Changelog/Done Required changelog entry has been written Docs/Not Needed Does not require documentation labels May 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crspeller crspeller crspeller approved these changes

@mickmister mickmister mickmister approved these changes

@asaadmahmood asaadmahmood asaadmahmood approved these changes

Assignees

@iomodo iomodo

Labels
Changelog/Done Required changelog entry has been written CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone Docs/Not Needed Does not require documentation QA Review Done
Projects
No open projects
Integrations Team
Done
Milestone
v5.24.0
8 participants
@iomodo @metanerd @DHaussermann @crspeller @mickmister @asaadmahmood @mattermod @amyblais