Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

MM-22064: Update verbage for domain restrictions #5491

Merged
merged 4 commits into from
May 21, 2020
Merged

MM-22064: Update verbage for domain restrictions #5491

merged 4 commits into from
May 21, 2020

Conversation

sbishel
Copy link
Member

@sbishel sbishel commented May 13, 2020 •
edited
Loading

Summary

Update verbage on domain restrictions.

Ticket Link

https://mattermost.atlassian.net/browse/MM-22064

Related Pull Requests

Screenshots

Screen Shot 2020-05-18 at 8 16 39 PM

@sbishel sbishel requested review from fmunshi and hahmadia May 13, 2020 18:37
@sbishel sbishel mentioned this pull request May 13, 2020
Merged
@sbishel sbishel added 1: PM Review Requires review by a product manager 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels May 13, 2020
thefactremains
thefactremains suggested changes May 13, 2020
View reviewed changes
Copy link

@thefactremains thefactremains left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies @sbishel After reading this again, I would like to update the wording a bit.
Restrict new members and teams to specified email domains:

@hahmadia hahmadia removed the 1: PM Review Requires review by a product manager label May 14, 2020
@hahmadia hahmadia removed the 2: Dev Review Requires review by a core commiter label May 14, 2020
@justinegeffen justinegeffen added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels May 14, 2020
@hahmadia hahmadia added 3: QA Review Requires review by a QA tester and removed 4: Reviews Complete All reviewers have approved the pull request labels May 14, 2020
@hahmadia hahmadia requested a review from srkgupta May 14, 2020 13:02
@srkgupta
Copy link
Contributor

@thefactremains I feel that the helper text displayed under this field needs an update too. Currently it only talks about the account creation and indicates this setting only affects email login for users.
User accounts can only be created from a specific domain (e.g. "mattermost.org") or list of comma-separated domains (e.g. "corp.mattermost.com, mattermost.org"). This setting only affects email login for users. For Guest users, please add domains under Signup > Guest Access.
Screenshot 2020-05-15 at 8 56 00 PM

Can you please confirm the new helper text if this needs to be changed?

@thefactremains
Copy link

@thefactremains I feel that the helper text displayed under this field needs an update too. Currently it only talks about the account creation and indicates this setting only affects email login for users.
User accounts can only be created from a specific domain (e.g. "mattermost.org") or list of comma-separated domains (e.g. "corp.mattermost.com, mattermost.org"). This setting only affects email login for users. For Guest users, please add domains under Signup > Guest Access.
Screenshot 2020-05-15 at 8 56 00 PM

Can you please confirm the new helper text if this needs to be changed?

yes, thank you @srkgupta

I suggest the following change:
New user accounts are restricted to the above specified email domain (e.g. "mattermost.org") or list of comma-separated domains (e.g. "corp.mattermost.com, mattermost.org"). New teams can only be created by users from the above domain(s). This setting affects email login for users. For Guest users, please add domains under Signup > Guest Access.

@sbishel
Copy link
Member Author

sbishel commented May 19, 2020

/update-branch

srkgupta
srkgupta approved these changes May 20, 2020
View reviewed changes
Copy link
Contributor

@srkgupta srkgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and the latest changes LGTM. Approving the PR.

@srkgupta srkgupta added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels May 20, 2020
@sbishel sbishel added this to the v5.26 milestone May 21, 2020
@sbishel sbishel merged commit cbc090c into mattermost:master May 21, 2020
@sbishel sbishel deleted the MM-22064-update-verbiage branch May 21, 2020 13:20
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels May 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@srkgupta srkgupta srkgupta approved these changes

@fmunshi fmunshi fmunshi approved these changes

@hahmadia hahmadia hahmadia approved these changes

@thefactremains thefactremains thefactremains approved these changes

@justinegeffen justinegeffen Awaiting requested review from justinegeffen

Assignees

@sbishel sbishel

Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation
Projects
None yet
Milestone
v5.26.0
8 participants
@sbishel @srkgupta @thefactremains @fmunshi @justinegeffen @hahmadia @amyblais @mattermod