Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

MM-24176: Regenerate invite code when making team private. #5475

Merged
merged 2 commits into from
May 19, 2020
Merged

MM-24176: Regenerate invite code when making team private. #5475

merged 2 commits into from
May 19, 2020

Conversation

grundleborg
Copy link
Contributor

Summary

Regenerate invite code when making team private.

Ticket Link

https://mattermost.atlassian.net/browse/MM-24176

Server PR: mattermost/mattermost#14529

@grundleborg grundleborg added 1: PM Review Requires review by a product manager 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels May 12, 2020
@grundleborg grundleborg added this to the v5.24.0 milestone May 12, 2020
@grundleborg grundleborg mentioned this pull request May 12, 2020
Merged
@lindy65 lindy65 added Setup Cloud Test Server Setup a test server using Mattermost Cloud and removed 2: Dev Review Requires review by a core commiter labels May 19, 2020
@lindy65
Copy link
Contributor

lindy65 commented May 19, 2020

Hey @grundleborg - I think the server PR needs merging before it'll work on this spinwick? Invite code not changing / updating on opening up a team to all users... Can you take a look please?

Also, just needing @wiersgallak review on this 👍

@grundleborg
Copy link
Contributor Author

/update-branch

@grundleborg
Copy link
Contributor Author

@lindy65 merged the server, but this is only a text change so as long as you see the new text in the UI about the invite ID getting regenerated if you change the invite setting then it's fine.

wiersgallak
wiersgallak approved these changes May 19, 2020
View reviewed changes
Copy link
Contributor

@wiersgallak wiersgallak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lindy65
lindy65 approved these changes May 19, 2020
View reviewed changes
Copy link
Contributor

@lindy65 lindy65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, thanks @grundleborg - text change is included in Team Settings >Allow any user with an account on this server to join this team > Changing from "Yes" to "No" will regenerate the invitation code, create a new invitation link and invalidate the previous link. 👍

@lindy65 lindy65 added 4: Reviews Complete All reviewers have approved the pull request and removed 1: PM Review Requires review by a product manager 3: QA Review Requires review by a QA tester Setup Cloud Test Server Setup a test server using Mattermost Cloud labels May 19, 2020
@mm-cloud-bot
Copy link

Test server destroyed

@grundleborg grundleborg merged commit d8c75ce into mattermost:master May 19, 2020
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@isacikgoz isacikgoz isacikgoz approved these changes

@jupenur jupenur jupenur approved these changes

@lindy65 lindy65 lindy65 approved these changes

@wiersgallak wiersgallak wiersgallak approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation
Projects
None yet
Milestone
v5.24.0
8 participants
@grundleborg @lindy65 @mm-cloud-bot @isacikgoz @jupenur @wiersgallak @amyblais @mattermod