This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
MM-24086:Disable changing picture if LDAP sync'ed #5465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbishel
added
2: Dev Review
mkraft
approved these changes
May 12, 2020
components/setting_picture.jsx
Outdated
| disabled={disableSaveButtonFocus} | ||
| ref={this.confirmButton} | ||
| className={confirmButtonClass} | ||
| onClick={this.props.loadingPicture ? () => true : this.handleSave} |
There was a problem hiding this comment.
The () => true function will create a new function every time causing unnecessary re-renders downstream vs creating a this.returnTrue method on the SettingPicture component.
sbishel
changed the title
|
/update-branch |
hahmadia
suggested changes
May 19, 2020
hahmadia
approved these changes
May 19, 2020
|
/update-branch |
srkgupta
approved these changes
May 20, 2020
srkgupta
added
4: Reviews Complete
amyblais
added
the
CherryPick/Approved
|
/cherry-pick release-5.24 |
mattermod
added
CherryPick/Done
sbishel
added a commit
that referenced
this pull request
May 20, 2020
* Disable changing picture if LDAP sync'ed * add imageContext property back, still used. * updates from code review * update for review * fix lint error Co-authored-by: Scott Bishel <[email protected]>
amyblais
added
Changelog/Not Needed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When LDAP sync is turned on and a Picture attribute is selected, the user will not be able to change the profile picture. Instead they will be displayed a message that the picture is controlled by LDAP settings. This is the same way other LDAP Attributes work.
Ticket Link
https://mattermost.atlassian.net/browse/MM-24086
Screenshots