This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
MM-24781 Make GM profiles API calls to be concurrent #5436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add p-queue as a dependdency and keep concurrency at 4 calls
sudheerDev
added
2: Dev Review
sudheerDev
commented
May 5, 2020
|
|
||
| await UserActions.loadProfilesForGM(); | ||
| expect(UserActions.queue.onEmpty).toHaveBeenCalled(); | ||
| expect(UserActions.queue.add).toHaveBeenCalled(); |
There was a problem hiding this comment.
i wanted to assert that we are calling an action here but it was becoming hard to mock the class etc.
sudheerDev
commented
May 5, 2020
| @@ -37,6 +37,7 @@ | |||
| "marked": "github:mattermost/marked#5a06d1af25ca48927b9efe0d9c42c01c84e7839b", | |||
| "mattermost-redux": "github:mattermost/mattermost-redux#9a915443ab1d695540493406926c3dd269d380fc", | |||
| "moment-timezone": "0.5.27", | |||
| "p-queue": "^6.4.0", | |||
There was a problem hiding this comment.
The footprint of the library small and it has good API which I intend to use in upcoming features like prefetching posts. It has API's for clearing, pausing and adding tasks dynamically too which fits perfectly for some of the upcoming features.
nevyangelova
approved these changes
May 5, 2020
Willyfrog
approved these changes
May 5, 2020
Co-authored-by: Guillermo Vayá <[email protected]>
sudheerDev
added
the
Setup Cloud Test Server
jgilliam17
approved these changes
May 14, 2020
There was a problem hiding this comment.
Thank you @sudheerDev
Tested, looks good to merge.
- Verified up to 4 requests are made at a time when there are many GMs on the sidebar.
Added test steps to the Jira ticket.
|
/update-branch |
jgilliam17
added
4: Reviews Complete
|
Test server destroyed |
|
New commit detected. SpinWick will upgrade if the updated docker image is available. |
|
Test server creation failed. See the logs for more information. |
amyblais
added
Changelog/Not Needed
bradjcoughlin
pushed a commit
to bradjcoughlin/mattermost-webapp
that referenced
this pull request
May 19, 2020
* MM-24781 Make GM profiles API calls to be concurrent * Add p-queue as a dependdency and keep concurrency at 4 calls * Update actions/user_actions.jsx Co-authored-by: Guillermo Vayá <[email protected]> Co-authored-by: Guillermo Vayá <[email protected]> Co-authored-by: mattermod <[email protected]>
bradjcoughlin
pushed a commit
to bradjcoughlin/mattermost-webapp
that referenced
this pull request
May 19, 2020
* MM-24781 Make GM profiles API calls to be concurrent * Add p-queue as a dependdency and keep concurrency at 4 calls * Update actions/user_actions.jsx Co-authored-by: Guillermo Vayá <[email protected]> Co-authored-by: Guillermo Vayá <[email protected]> Co-authored-by: mattermod <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
On the web, we now make one call at a time for GM profiles as attached in the screenshot. This can be improved by making 4 calls at a time in parallel and adding a new request to the stack when one finishes.
Making multiple calls will fetch all profiles sooner and instead of blocking the network stack with all the requests at once, we can cap them at 4. The reason to cap them at 4 is to have a little room for other network requests to go through in case they are needed while these are pending.
Ticket Link
https://mattermost.atlassian.net/browse/MM-24781
Screenshots
Before
After
