Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

MM-24351 Update react virt list to be based on new library #5399

Merged
merged 6 commits into from
Jun 11, 2020

Conversation

sudheerDev
Copy link
Contributor

Summary

Updating react window to be based on new repo https://github.com/mattermost/dynamic-virtualized-list
This includes minor cleanup made for library API which reflects the changes made in the PR.

Ticket Link

https://mattermost.atlassian.net/browse/MM-24351

Note: testing will be a smoke testing scroll, loading posts, switching channels

@sudheerDev sudheerDev added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Apr 27, 2020
@sudheerDev sudheerDev added this to the v5.24.0 milestone Apr 27, 2020
@Willyfrog
Copy link
Contributor

/update-branch

@hmhealey
Copy link
Member

I'd be interested in learning more about the library at some point. Maybe a blog post or a demo of some sort? 🙂

@hmhealey hmhealey removed the 2: Dev Review Requires review by a core commiter label Apr 28, 2020
@jgilliam17
Copy link
Contributor

Adding testing steps, per discussion with Sudheer

This requires a smoke test around scroll conditions, including, but not limited to:

  • loading more posts
  • checking if landing on unread post works etc
  • switching channel and coming back
  • posting new post to keep at bottom

@jgilliam17 jgilliam17 added the Setup Cloud Test Server Setup a test server using Mattermost Cloud label May 14, 2020
@jgilliam17
Copy link
Contributor

jgilliam17 commented May 14, 2020

Thank you @sudheerDev

  1. I am not able to add new posts on any of the channels/DMs
    edited: Messages post, but remain out of view. Posts can be searched for and display on the RHS, emojis have strange background disregard that's just highlight

Screen Shot 2020-05-14 at 5 55 18 PM

  1. Also, text "Beginning of..." text is missing. See image.

Screen Shot 2020-05-14 at 5 45 31 PM

  1. Any attempt to resize browser window causes white screen

@sudheerDev sudheerDev removed this from the v5.24.0 milestone May 19, 2020
@stylianosrigas stylianosrigas added Setup Cloud Test Server Setup a test server using Mattermost Cloud and removed Setup Cloud Test Server Setup a test server using Mattermost Cloud labels Jun 4, 2020
@stylianosrigas
Copy link

I had to remove the Setup Cloud Test Server label because we need to deprecate the cluster the installation is running. Reapplied successfully.

@sudheerDev sudheerDev added Setup Cloud Test Server Setup a test server using Mattermost Cloud and removed Setup Cloud Test Server Setup a test server using Mattermost Cloud labels Jun 9, 2020
@mm-cloud-bot mm-cloud-bot removed the Setup Cloud Test Server Setup a test server using Mattermost Cloud label Jun 9, 2020
@sudheerDev sudheerDev added Setup Cloud Test Server Setup a test server using Mattermost Cloud and removed Setup Cloud Test Server Setup a test server using Mattermost Cloud labels Jun 9, 2020
@sudheerDev
Copy link
Contributor Author

/update-branch

@sudheerDev sudheerDev added the Setup Cloud Test Server Setup a test server using Mattermost Cloud label Jun 9, 2020
@sudheerDev
Copy link
Contributor Author

@jgilliam17 Can you test this again?

@jgilliam17 jgilliam17 added Setup Cloud Test Server Setup a test server using Mattermost Cloud and removed Setup Cloud Test Server Setup a test server using Mattermost Cloud labels Jun 10, 2020
@jgilliam17
Copy link
Contributor

/update-branch

Copy link
Contributor

@jgilliam17 jgilliam17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @sudheerDev
Tested, looks good to merge.

  • Verified scrolling and loading more posts, including unreads, switching channels and user remaining at the bottom when adding new post.
    Thank you! @saturninoabril for running the E2Es here

@jgilliam17 jgilliam17 added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester Setup Cloud Test Server Setup a test server using Mattermost Cloud labels Jun 11, 2020
@mm-cloud-bot
Copy link

Test server destroyed

@sudheerDev sudheerDev merged commit 4878121 into mattermost:master Jun 11, 2020
@sudheerDev sudheerDev deleted the MM-24351 branch June 11, 2020 20:28
@sudheerDev sudheerDev added this to the v5.26 milestone Jun 11, 2020
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Jul 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation
Projects
None yet
8 participants