This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
[MM-23384] Readded div to wrap around contents of OverlayTrigger #5386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinbinnie
added
2: Dev Review
ghost
requested review from
bradjcoughlin and
jfrerich
and removed request for
a team
jgilliam17
added
the
Setup Cloud Test Server
mm-cloud-bot
removed
the
Setup Cloud Test Server
|
Test server destroyed |
1 similar comment
|
Test server destroyed |
jgilliam17
added
the
Setup Cloud Test Server
mm-cloud-bot
removed
the
Setup Cloud Test Server
|
Test server destroyed |
1 similar comment
|
Test server destroyed |
jgilliam17
added
the
Setup Cloud Test Server
|
Test server creation failed. See the logs for more information. |
mm-cloud-bot
removed
the
Setup Cloud Test Server
|
Mattermost test server created! 🎉 Access here: https://mattermost-webapp-pr-5386.test.mattermost.cloud
|
jgilliam17
approved these changes
Apr 24, 2020
There was a problem hiding this comment.
Thank you @devinbinnie
Tested on webapp and desktop app, looks good to merge.
- Verified hover tooltip showing the whole name is present for channels with truncated (long) names on the LHS
*Verified on old and new sidebar.
jgilliam17
added
QA Review Done
and removed
3: QA Review
jfrerich
approved these changes
Apr 27, 2020
|
@bradjcoughlin Kind reminder to review this. Code complete for v5.23 is tomorrow |
bradjcoughlin
approved these changes
Apr 28, 2020
bradjcoughlin
added
the
4: Reviews Complete
|
Automated cherry picking currently disabled. |
devinbinnie
added a commit
to devinbinnie/mattermost-webapp
that referenced
this pull request
Apr 28, 2020
…termost#5386) * [MM-23384] Readded div to wrap around contents of OverlayTrigger * Fixed a test
devinbinnie
added a commit
that referenced
this pull request
Apr 28, 2020
amyblais
added
CherryPick/Done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When a channel name is too long for the sidebar, there should be a tooltip that pops up when hovering over the channel to show the full name. This was broken on Desktop with the new sidebar.
This PR re-adds a
divelement needed for theOverlayTrigger, and also re-inserts code to remove the extraariatag.Ticket Link
https://mattermost.atlassian.net/browse/MM-23384