[MM-24356] Dispatch getChannelMemberCountsByGroup if timezones are enabled when user is updated #5357
Conversation
fmunshi
added
2: Dev Review
fmunshi
force-pushed
the
MM-24356-Timezone-count
branch
from
0658fbb
to
7de5122
Compare
| const config = getConfig(state); | ||
| const isTimezoneEnabled = config.ExperimentalTimezone === 'true'; | ||
| const userIsGuest = isGuest(user); | ||
| if (userIsGuest || isTimezoneEnabled) { |
There was a problem hiding this comment.
I don't know the background: why is this branching statement only for guests?
There was a problem hiding this comment.
Im not sure what the background was either but it just so happened I needed the same logic for getChannelMemberCounts... that was being done for guest users
| }); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
There seems to be a hefty amount of logic in both create_post.jsx and create_comment.jsx, which makes sense but my only callout would be to consider if there's any opportunity for reuse?
There was a problem hiding this comment.
Agreed @mkraft - but this PR never actually had changes to that file that was from Hosseins previous PR that this was built off of. Maybe we can make a ticket to cleanup and reduce duplication between the two files
There was a problem hiding this comment.
Yeah for sure. I was thinking this was new code. NVM then.
fmunshi
force-pushed
the
MM-24356-Timezone-count
branch
from
ef088e0
to
7785609
Compare
There was a problem hiding this comment.
Now the webapp makes a request to get the members_count_by_group whenever the Timezone information was changed by a different user. However while testing this PR, there was an another issue found which has been raised separately. https://mattermost.atlassian.net/browse/MM-24674.
Expecting a separate fix for that issue, since it's not related to the original ticket. Approving this PR.
srkgupta
added
4: Reviews Complete
amyblais
added
Changelog/Not Needed
Summary
getChannelMemberCountsByGroupwhen a user updates is called in order to ensure timezone counts are accurate since a user may change their timezone resulting in the confirmation modal displaying out of date information if the page hasnt been reloaded in a while.Ticket Link