This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
Shortcuts modal and Emoji picker UI Fixes #5338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asaadmahmood
requested review from
sudheerDev,
saturninoabril,
jasonblais and
jgilliam17
asaadmahmood
added
2: Dev Review
jasonblais
added
the
Setup Cloud Test Server
|
I can see the tip now, but the bottom of the modal gets cut off on the Mattermost window (same environment as in Jira ticket)
Compared to 5.21: @asaadmahmood I realize it's because there are now a lot more shortcuts under "Navigation" |
|
@jasonblais Yup, we have a lot more items, and we may have more in the future too, so it may not be possible to keep the modal visible completely at all times, especially on smaller resolutions. |
|
@jasonblais I made it smaller on small screen heights like yours, check it out. |
jasonblais
approved these changes
Apr 15, 2020
saturninoabril
approved these changes
Apr 15, 2020
asaadmahmood
requested review from
marianunez
and removed request for
jgilliam17 and
sudheerDev
marianunez
approved these changes
Apr 17, 2020
|
Mattermost test server updated with git commit Access here: https://mattermost-webapp-pr-5338.test.mattermost.cloud |
|
Test server destroyed |
hanzei
removed
the
Setup Cloud Test Server
amyblais
added
Changelog/Not Needed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
MM-24130 - Reducing spacing in keyboard shortcuts modal
MM-24159 - Updating emoji picker hover effect
@jasonblais Can you test this PR out on your screen, on my screen it looked good even previously, but reduced the spacing for you.
Ticket Link
https://mattermost.atlassian.net/browse/MM-24130
https://mattermost.atlassian.net/browse/MM-24159
Screenshots