Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

Fix username, fullname, nickname #5332

Merged

Conversation

josephbaylon
Copy link
Contributor

Summary

Fix tests failing on username, fullname, nickname

Ticket Link

NA

@josephbaylon josephbaylon added the 3: QA Review Requires review by a QA tester label Apr 14, 2020
Copy link
Contributor

@srkgupta srkgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@josephbaylon I am seeing failures. These tests are failing at a different point. Can you please check and fix them. There were more tests failing, but I had stopped because many of them failed with same reason.

Screenshot 2020-04-14 at 10 01 02 PM

@josephbaylon
Copy link
Contributor Author

@srkgupta I'm not getting those failures locally. We can probably address those when they fail on cypress server?
Screen Shot 2020-04-14 at 10 43 02 AM

Copy link
Contributor

@srkgupta srkgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok sure. I will approve them for now.

@srkgupta srkgupta added QA Review Done and removed 3: QA Review Requires review by a QA tester labels Apr 14, 2020
@srkgupta srkgupta merged commit 8fc4576 into mattermost:master Apr 14, 2020
@josephbaylon josephbaylon deleted the fix-username-fullname-nickname branch April 14, 2020 17:46
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation QA Review Done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants