This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
[MM-23995] [MM-23996] Fix improper rendering of bot profile picture and bot roles #5294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 8, 2020 13:54
fmunshi
added
2: Dev Review
ghost
requested review from
amyblais
added
the
CherryPick/Approved
crspeller
approved these changes
Apr 9, 2020
DHaussermann
added
the
Setup Cloud Test Server
DHaussermann
approved these changes
Apr 13, 2020
There was a problem hiding this comment.
Tested and passed
Both issues are resolved.
When editing am existing bot, the profile image remains visible. The role drop down displays correctly.
LGTM! Thanks @fmunshi for this fix!
Please merge.
DHaussermann
added
4: Reviews Complete
|
Test server destroyed |
mattermod
added
CherryPick/Done
fmunshi
pushed a commit
that referenced
this pull request
Apr 13, 2020
* MM-23995 Pass bot user to props correctly * MM-23996 Dont use formatted message inside of option select instead use utils method Co-authored-by: fm2munsh <[email protected]>
amyblais
added
Changelog/Not Needed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
FormattedMessagewas used as a select option resulting inobject Objectbeing shown as the textgetUsers(state)[id]intogetUser(state, id)Ticket Link
Screenshots