Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

[MM-23899] Revert "Remove extra line break in reaction overlay" #5278

Merged
merged 1 commit into from
Apr 7, 2020
Merged

[MM-23899] Revert "Remove extra line break in reaction overlay" #5278

merged 1 commit into from
Apr 7, 2020

Conversation

fmunshi
Copy link
Contributor

@fmunshi fmunshi commented Apr 6, 2020

Summary

  • Reverting my change made here [MM-23449] Remove extra line break in reaction overlay #5161 since it seems like this line break is needed once more.
  • I'm not sure how there were multiple line breaks occurring before but I am entirely unable to reproduce that on master now after re-adding in the original line break. I'm assuming that it was some css that was modified that I cant find.

Ticket Link

https://mattermost.atlassian.net/browse/MM-23899

Screenshots

Before
Screen Shot 2020-04-06 at 6 04 36 PM

After
Screen Shot 2020-04-06 at 6 03 35 PM

@fmunshi fmunshi added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Apr 6, 2020
@fmunshi fmunshi added this to the v5.22.0 milestone Apr 6, 2020
@fmunshi fmunshi added CherryPick/Approved Meant for the quality or patch release tracked in the milestone Docs/Not Needed Does not require documentation labels Apr 6, 2020
@amyblais amyblais removed the 2: Dev Review Requires review by a core commiter label Apr 7, 2020
@lindalumitchell lindalumitchell added the Setup Cloud Test Server Setup a test server using Mattermost Cloud label Apr 7, 2020
lindalumitchell
lindalumitchell approved these changes Apr 7, 2020
View reviewed changes
Copy link
Contributor

@lindalumitchell lindalumitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified on test server that the Click to add or Click to remove appears on its own line. Tested reactions in center and reply thread, with one user and multiple users, on browser and desktop app, in standard view and narrow mobile view, on RN. LGTM.

@lindalumitchell lindalumitchell added QA Review Done and removed 3: QA Review Requires review by a QA tester labels Apr 7, 2020
@amyblais amyblais added the 4: Reviews Complete All reviewers have approved the pull request label Apr 7, 2020
@fmunshi fmunshi removed the Setup Cloud Test Server Setup a test server using Mattermost Cloud label Apr 7, 2020
@mattermod
Copy link
Contributor

Test server destroyed

@fmunshi fmunshi merged commit 775445f into mattermost:master Apr 7, 2020
@mattermost-build mattermost-build mentioned this pull request Apr 7, 2020
Merged
@fmunshi fmunshi deleted the MM-23899 branch April 7, 2020 19:32
@mattermod mattermod added CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone and removed CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Apr 7, 2020
@amyblais amyblais added the Changelog/Not Needed Does not require a changelog entry label Apr 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@asaadmahmood asaadmahmood asaadmahmood approved these changes

@lindalumitchell lindalumitchell lindalumitchell approved these changes

@devinbinnie devinbinnie devinbinnie approved these changes

Assignees

@fmunshi fmunshi

Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone Docs/Not Needed Does not require documentation QA Review Done
Projects
None yet
Milestone
v5.22.0
6 participants
@fmunshi @mattermod @asaadmahmood @lindalumitchell @devinbinnie @amyblais