This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
Fixed few failures related to toast_spec & System Scheme #5257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saturninoabril
approved these changes
Apr 2, 2020
josephbaylon
approved these changes
Apr 2, 2020
josephbaylon
added
QA Review Done
and removed
3: QA Review
amyblais
added
Changelog/Not Needed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Deleted create_post_permission_spec as this was modifying system scheme within the test and removing create_posts permission. We have detailed tests in form of channel_moderation_spec which validates create_posts permission & other channel moderation settings. Hence removing this problematic test which is no longer required.
Updated few steps in toast_spec so that all the test passes.
Increased the timeout in cypress.json file from 20 seconds to 60 seconds as some of the pages takes a long time to load.
Ticket Link
N/A. Fixed based on analysis of daily runs.
Screenshots