This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
MM-23660 - Updating emoji popup on desktop and mobile #5230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asaadmahmood
added
2: Dev Review
asaadmahmood
requested review from
saturninoabril,
lindalumitchell and
devinbinnie
amyblais
added
the
CherryPick/Approved
devinbinnie
approved these changes
Mar 30, 2020
saturninoabril
added
the
Setup Cloud Test Server
saturninoabril
approved these changes
Mar 31, 2020
There was a problem hiding this comment.
Tested and looks good per emoji popup. However, I'm confused if https://mattermost.atlassian.net/browse/MM-23457 is the correct ticket. PTAL.
|
@saturninoabril Thanks, updated the ticket. |
lindalumitchell
approved these changes
Apr 1, 2020
There was a problem hiding this comment.
Looks good to me; tested making a custom emoji using a file that repro'ed the issue, and it looked fine (attached that test file and sample screenshots to the ticket). Tested emoji picker in mobile view and double-checked in standard view. Checked in message box and reactions, in center and reply thread.
lindalumitchell
added
QA Review Done
and removed
3: QA Review
|
Test server destroyed |
mattermod
added
CherryPick/Done
amyblais
added
Changelog/Not Needed
hanzei
added
4: Reviews Complete
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
MM-23660 - Updating emoji popup on desktop and mobile
Ticket Link
https://mattermost.atlassian.net/browse/MM-23660
Screenshots