[MM-20550] Convert email notification setting to typescript

[hiendinhngoc]

Summary

Migrate 'components/user_settings/notifications/email_notification_setting' module and associated tests to TypeScript

Ticket Link

Fixes mattermost/mattermost#13691
JIRA: https://mattermost.atlassian.net/browse/MM-20550

[hiendinhngoc]

I temporarily set enableEmailBatching to number type because getEmailInterval requires number type at the second argument. Please suggest the correct way to deal with enableEmailBatching

[hanzei]

NVM @agnivade, GH played tricks on me

[hanzei]

/update-branch

[devinbinnie]

@hiendinhngoc Looks like the type on getEmailInterval is wrong, the parameter enableEmailBatching should be a boolean. I can make a fix for that, work under the assumption that it's a boolean. Sorry about that.

[devinbinnie]

mattermost/mattermost-redux#1102

[devinbinnie]

/update-branch

[devinbinnie]

@hiendinhngoc The fix has been merged, and I've updated the branch for you.
There are some tests failing, which I've indicated below. Please make sure to git pull on your branch before making any changes.

Summary of all failing tests
 FAIL  components/user_settings/notifications/email_notification_setting/email_notification_setting.test.tsx
  ● components/user_settings/notifications/EmailNotificationSetting › should match snapshot

    expect(received).toMatchSnapshot()

    Snapshot name: `components/user_settings/notifications/EmailNotificationSetting should match snapshot 1`

    - Snapshot
    + Received

    @@ -6,11 +6,11 @@
        }
        activeSection="email"
        currentUserId="current_user_id"
        emailInterval={0}
        enableEmail={false}
    -   enableEmailBatching={0}
    +   enableEmailBatching={false}
        onCancel={[MockFunction]}
        onChange={[MockFunction]}
        onSubmit={[MockFunction]}
        saving={false}
        sendEmailNotifications={true}

      32 |         const wrapper = mountWithIntl(<EmailNotificationSetting {...requiredProps}/>);
      33 | 
    > 34 |         expect(wrapper).toMatchSnapshot();
         |                         ^
      35 |         expect(wrapper.find('#emailNotificationImmediately').exists()).toBe(true);
      36 |         expect(wrapper.find('#emailNotificationNever').exists()).toBe(true);
      37 |         expect(wrapper.find('#emailNotificationMinutes').exists()).toBe(false);

      at Object.test (components/user_settings/notifications/email_notification_setting/email_notification_setting.test.tsx:34:25)

  ● components/user_settings/notifications/EmailNotificationSetting › should match snapshot, enabled email batching

    expect(received).toMatchSnapshot()

    Snapshot name: `components/user_settings/notifications/EmailNotificationSetting should match snapshot, enabled email batching 1`

    - Snapshot
    + Received

    @@ -6,11 +6,11 @@
        }
        activeSection="email"
        currentUserId="current_user_id"
        emailInterval={0}
        enableEmail={false}
    -   enableEmailBatching={1}
    +   enableEmailBatching={true}
        onCancel={[MockFunction]}
        onChange={[MockFunction]}
        onSubmit={[MockFunction]}
        saving={false}
        sendEmailNotifications={true}

      46 |         const wrapper = mountWithIntl(<EmailNotificationSetting {...props}/>);
      47 | 
    > 48 |         expect(wrapper).toMatchSnapshot();
         |                         ^
      49 |         expect(wrapper.find('#emailNotificationMinutes').exists()).toBe(true);
      50 |         expect(wrapper.find('#emailNotificationHour').exists()).toBe(true);
      51 |     });

      at Object.test (components/user_settings/notifications/email_notification_setting/email_notification_setting.test.tsx:48:25)


Snapshot Summary
 › 2 snapshots failed from 1 test suite. Inspect your code changes or run `npm run test-ci -- -u` to update them.

[hiendinhngoc]

@devinbinnie I updated, pls check

[devinbinnie]

Looks good overall, just a couple comments.

[devinbinnie]

Looking good now, thanks @hiendinhngoc!

[stylianosrigas]

Removing the test server for maintenance purposes. Please add the label again if you need it. Sorry for any inconvenience.

[hiendinhngoc]

@DHaussermann hi, I updated the code to fix the issue, please check it when you have time, thanks.

[DHaussermann]

Tested and passed

• Issue mentioned above is resolved
• Briefly regression tested this product area
• As a precaution I made sure the never / immediately setting still works as expected based on which option is selected
  LGTM!
  No need for any updates to release tests.

Re-requested a dev review for last commit. Will test again if there are any further changes needed.

Well done @hiendinhngoc! Huge thanks for your continued effort on this. Much appreciated.

[devinbinnie]

Thanks @hiendinhngoc, this is working well now. Appreciate your dedication and hard work :)

[mm-cloud-bot]

Test server destroyed

[mm-cloud-bot]

Test server destroyed