This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
MM-22825 Add E2E on skipping Slack-compatible interactive message response #5183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srkgupta
suggested changes
Mar 26, 2020
There was a problem hiding this comment.
Hi @saturninoabril
I am consistently seeing this failure. Can you please check. I have ensured that I have the latest code from master branch on webapp & server.
expected <div#postMessageText_p39noqxztbnwbd4hfmb3oe7krw.post-message__text> to have HTML <p>a < a | b > a</p>, but the HTML was <p>a <a class="theme markdown__link" href="https://a" rel="noreferrer" target="_blank"> b </a> a</p>
|
@srkgupta It requires server change which is not yet merged at the time of your testing. Please update again to master and see how it's working for you, thanks |
srkgupta
approved these changes
Mar 26, 2020
There was a problem hiding this comment.
Thanks @saturninoabril. Tested it on the latest master and now the test is working fine. Approving the PR
mickmister
approved these changes
Mar 26, 2020
josephbaylon
approved these changes
Mar 26, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test Steps:
Text:
a < a | b > aTicket Link
JIRA ticket - https://mattermost.atlassian.net/browse/MM-22825
Related Pull Requests
"skip_slack_parsing"to PostActionIntegrationResponse. mattermost#13976)