Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

migrating lhs and rhs selectors to typescript #5180

Merged
merged 6 commits into from
Apr 15, 2020

Conversation

jespino
Copy link
Member

@jespino jespino commented Mar 26, 2020

Summary

migrating lhs and rhs selectors to typescript

Ticket Link

MM-23619

@jespino jespino added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester Work in Progress Not yet ready for review and removed 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Mar 26, 2020
@jespino jespino requested a review from devinbinnie April 1, 2020 12:45
@jespino jespino added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester and removed Work in Progress Not yet ready for review labels Apr 1, 2020
@jespino jespino requested a review from Willyfrog April 1, 2020 12:46
Copy link
Member

@devinbinnie devinbinnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Willyfrog Willyfrog removed the 2: Dev Review Requires review by a core commiter label Apr 3, 2020
@jespino
Copy link
Member Author

jespino commented Apr 9, 2020

/update-branch

@jgilliam17 jgilliam17 added the Setup Cloud Test Server Setup a test server using Mattermost Cloud label Apr 14, 2020
Copy link
Contributor

@jgilliam17 jgilliam17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jespino
Tested, looks good to merge.

  • Smoke tested around LHS and RHS

@jgilliam17 jgilliam17 added QA Review Done and removed 3: QA Review Requires review by a QA tester Setup Cloud Test Server Setup a test server using Mattermost Cloud labels Apr 14, 2020
@mattermod
Copy link
Contributor

Test server destroyed

@jespino
Copy link
Member Author

jespino commented Apr 14, 2020

/update-branch

@jespino jespino added the 4: Reviews Complete All reviewers have approved the pull request label Apr 14, 2020
@jespino jespino self-assigned this Apr 14, 2020
@jespino jespino merged commit 03fe6ae into mattermost:master Apr 15, 2020
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Apr 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation QA Review Done
Projects
None yet
6 participants