Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

Adding support for the new field for team_name in the post mentions #5152

Merged
merged 2 commits into from
Mar 31, 2020

Conversation

jespino
Copy link
Member

@jespino jespino commented Mar 25, 2020

Summary

Adding support for the new field for team_name in the post mentions. This is
added in the server PR (referenced at the bottom). At the same time, if the
field is not found in the post props it keeps the old behavior.

Ticket Link

MM-22476

Related Pull Requests

@jespino jespino added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Mar 25, 2020
@jespino jespino added this to the v5.22.0 milestone Mar 25, 2020
@jespino jespino added the CherryPick/Approved Meant for the quality or patch release tracked in the milestone label Mar 25, 2020
Copy link
Member

@wiggin77 wiggin77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@amyblais amyblais removed the CherryPick/Approved Meant for the quality or patch release tracked in the milestone label Mar 27, 2020
@amyblais amyblais modified the milestones: v5.22.0, v5.23.0 Mar 27, 2020
@mgdelacroix mgdelacroix removed the 2: Dev Review Requires review by a core commiter label Mar 30, 2020
@lindy65 lindy65 added the Setup Cloud Test Server Setup a test server using Mattermost Cloud label Mar 30, 2020
Copy link
Contributor

@lindy65 lindy65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jespino - tested as per steps in ticket's description and this is working as expected 👍

@lindy65 lindy65 added QA Review Done and removed 3: QA Review Requires review by a QA tester Setup Cloud Test Server Setup a test server using Mattermost Cloud labels Mar 30, 2020
@mattermod
Copy link
Contributor

Test server destroyed

@jespino
Copy link
Member Author

jespino commented Mar 30, 2020

/update-branch

@hmhealey
Copy link
Member

@jespino I just saw that this went in. How does this work when the mentions come from the post? When the ChannelNamesMap is passed in by the Markdown component (link), that object doesn't have a team_name field. The getChannelsNameMapInCurrentTeam selector in mattermost-redux needs to be updated to support the team_name field or else we could cause problems.

@amyblais amyblais added the CherryPick/Approved Meant for the quality or patch release tracked in the milestone label Apr 15, 2020
@jespino jespino added CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone and removed CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Apr 22, 2020
@amyblais
Copy link
Member

@jespino Has this comment been resolved #5152 (comment)?

@jespino
Copy link
Member Author

jespino commented Apr 24, 2020

@hmhealey this works because we are adding that information through the server side PR. That information is only added for the new posts, but if the post doesn't provide this new information we simply not included the fix. That means, the fix is going to work for any new link created, but is going to keep working as was working before for any old post.

@amyblais amyblais added Changelog/Done Required changelog entry has been written Docs/Not Needed Does not require documentation labels Apr 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Changelog/Done Required changelog entry has been written CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone Docs/Not Needed Does not require documentation QA Review Done
Projects
None yet
7 participants