This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
[MM-23447] Fixes swith teams shortcut after reorder teams feature was added #5078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmhealey
approved these changes
Mar 19, 2020
srkgupta
approved these changes
Mar 20, 2020
There was a problem hiding this comment.
Tested the changes on Browser & Desktop and the team shortcuts are now working fine. The only issue which I saw was the Team drag & drop was not working on the Desktop, but after discussing with @mgdelacroix and after testing on the latest 5.22 instance, it was observed there as well and was nothing to do with this PR. I will be raising this as a separate issue in JIRA.
|
Test server destroyed |
|
@srkgupta ticket already filed for this: https://mattermost.atlassian.net/browse/MM-23448 |
jespino
approved these changes
Mar 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The merge of #3678 didn't play well with the new team drag&drop feature, not showing the indicators when pressing
Ctrl + Altand not taking into account the user's team order when using the shortcut.This PR fixes both issues
Ticket Link
https://mattermost.atlassian.net/browse/MM-23447