This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
[MM 23264] Show Confirmation Modal for group mentions #5065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelgamble
approved these changes
Mar 17, 2020
c9a4dfd
to
37deb4c
Compare
fmunshi
reviewed
Mar 18, 2020
fmunshi
reviewed
Mar 18, 2020
| values={Object {}} | ||
| /> | ||
| } | ||
| title="" |
There was a problem hiding this comment.
why are these emptied (throughout the file)?
There was a problem hiding this comment.
This is because prior to my change, the title were always getting set regardless if the confirmation modal was being shown or not. In my change, I start them off as blank and only set them if needed. So they don't won't always have values associated to them unless we will display the confirmation modal.
catalintomai
approved these changes
Mar 18, 2020
5099a43
to
3a5a6dd
Compare
make warning dialogue appear for group mentions and all channel mentions fix linting and i18n extract address UX concerns regarding wording for group dialogue fix lint and add tests address PR comments update text in UI to include group mentions
63fafb5
to
d4f69ab
Compare
fmunshi
approved these changes
Mar 18, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Show the confirmation modal for group mentions
Ticket Link
https://mattermost.atlassian.net/browse/MM-23264
Related Pull Requests
mattermost/mattermost#14068
mattermost/mattermost-redux#1086