Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

Fix messaging specs #5052

Merged
merged 2 commits into from
Mar 13, 2020
Merged

Conversation

josephbaylon
Copy link
Contributor

Summary

Fix failing specs on messaging, at mentions, elastic search, and interactive dialog. Added new plugin for clipboard.

Ticket Link

NA

Copy link
Member

@saturninoabril saturninoabril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All passed, except for some comments, thanks

@saturninoabril saturninoabril added the 3: QA Review Requires review by a QA tester label Mar 13, 2020
Copy link
Member

@saturninoabril saturninoabril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

Copy link
Contributor

@srkgupta srkgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM.

@srkgupta srkgupta added QA Review Done and removed 3: QA Review Requires review by a QA tester labels Mar 13, 2020
@srkgupta srkgupta merged commit 2261410 into mattermost:master Mar 13, 2020
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Mar 13, 2020
sowmiyamuthuraman pushed a commit to sowmiyamuthuraman/mattermost-webapp that referenced this pull request Apr 10, 2020
* Fix messaging specs

* Fix post_header_spec
@josephbaylon josephbaylon deleted the fix-messaging-specs branch April 14, 2020 15:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation QA Review Done
Projects
None yet
4 participants