This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
Add suppport for image links to be previewed #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esethna
added
Awaiting Submitter Action
|
@miguelespinoza please see the comment about "Get Public Link". |
|
@esethna I've added the fix for that 😄 |
miguelespinoza
force-pushed
the
image-link-preview
branch
from
28e6ee6
to
358474f
Compare
dmeza
force-pushed
the
image-link-preview
branch
from
358474f
to
d56bb85
Compare
|
@lfbrock please help us test these PR. It's rebased to the latest from master. |
jasonblais
removed
Awaiting Submitter Action
|
|
|
Spinmint test server created at: http:https://i-0c13b036dec81909f.spinmint.com Test Account 1: Email: Test Account 2: Email: Instance ID: i-0c13b036dec81909f |
lfbrock
dismissed
esethna’s stale review
Changes have been made, Eric is away so dismissing review since he's not here to approve
lfbrock
approved these changes
Jan 4, 2018
|
Spinmint test server destroyed |
lfbrock
added
2: Dev Review
saturninoabril
approved these changes
Jan 9, 2018
jwilander
approved these changes
Jan 10, 2018
jwilander
added
4: Reviews Complete
dmeza
pushed a commit
to uber-archive/mattermost-webapp
that referenced
this pull request
Jan 10, 2018
* Add suppport for image links to be previewed * Do not display Public Link for inline link images * updated snapshots
dmeza
pushed a commit
to uber-archive/mattermost-webapp
that referenced
this pull request
Jan 10, 2018
* Add suppport for image links to be previewed * Do not display Public Link for inline link images * updated snapshots
dmeza
pushed a commit
to uber-archive/mattermost-webapp
that referenced
this pull request
Jan 15, 2018
* Add suppport for image links to be previewed * Do not display Public Link for inline link images * updated snapshots
dmeza
pushed a commit
to uber-archive/mattermost-webapp
that referenced
this pull request
Jan 15, 2018
* Add suppport for image links to be previewed * Do not display Public Link for inline link images * updated snapshots
dmeza
pushed a commit
to uber-archive/mattermost-webapp
that referenced
this pull request
Jan 29, 2018
* Add suppport for image links to be previewed * Do not display Public Link for inline link images * updated snapshots
amyblais
added
Changelog/Done
esethna
added
Docs/Not Needed
hmhealey
pushed a commit
that referenced
this pull request
Aug 28, 2020
* fix combined posts which ignores custom and other post types * removed console log and added assertions of posts Signed-off-by: Saturnino Abril <[email protected]>
hmhealey
pushed a commit
that referenced
this pull request
Mar 17, 2021
* fix combined posts which ignores custom and other post types * removed console log and added assertions of posts Signed-off-by: Saturnino Abril <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Preview link images just like you do with images uploaded from MM.
Checklist
Screenshots