Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

MM-22989 - Adding reply count to root posts in RHS (Search, Flags, Pinned) #5031

Merged
merged 3 commits into from
Mar 12, 2020
Merged

MM-22989 - Adding reply count to root posts in RHS (Search, Flags, Pinned) #5031

merged 3 commits into from
Mar 12, 2020

Conversation

asaadmahmood
Copy link
Contributor

@asaadmahmood asaadmahmood commented Mar 10, 2020

Summary

MM-22989 - Adding reply count to root posts in RHS
Comment count should be added in the search sidebar for root posts.

Ticket Link

https://mattermost.atlassian.net/browse/MM-22989

Screenshots

Screenshot 2020-03-10 at 5 15 54 PM

@asaadmahmood asaadmahmood added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Mar 10, 2020
@stevemudie stevemudie added the Setup Cloud Test Server Setup a test server using Mattermost Cloud label Mar 10, 2020
Copy link
Contributor

@stevemudie stevemudie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Really nice touch being able to directly access a thread with a single click.

@stevemudie stevemudie added QA Review Done and removed 3: QA Review Requires review by a QA tester labels Mar 10, 2020
@asaadmahmood
Copy link
Contributor Author

@saturninoabril Done, have a look.

@asaadmahmood asaadmahmood changed the title MM-22989 - Adding reply count to root posts in search RHS MM-22989 - Adding reply count to root posts in RHS (Search, Flags, Pinned) Mar 11, 2020
@mattermod
Copy link
Contributor

Mattermost test server updated with git commit 97363964703cd9f2dbd6b460488b396aaa14c6d5.

Access here: https://mattermost-webapp-pr-5031.test.mattermost.cloud

Copy link
Member

@saturninoabril saturninoabril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

@esethna esethna added this to the v5.22.0 milestone Mar 11, 2020
Copy link
Contributor

@sudheerDev sudheerDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sudheerDev sudheerDev added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter Setup Cloud Test Server Setup a test server using Mattermost Cloud labels Mar 12, 2020
@mattermod
Copy link
Contributor

Test server destroyed

@sudheerDev sudheerDev merged commit de49f85 into mattermost:master Mar 12, 2020
@asaadmahmood asaadmahmood deleted the MM-22989 branch March 12, 2020 19:51
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Mar 13, 2020
@stevemudie stevemudie added the Setup Cloud Test Server Setup a test server using Mattermost Cloud label Mar 27, 2020
@mattermod
Copy link
Contributor

Creating a new SpinWick test server using Mattermost Cloud.

@mattermod
Copy link
Contributor

Mattermost test server created! 🎉

Access here: https://mattermost-webapp-pr-5031.test.mattermost.cloud

Account Type Username Password
Admin sysadmin Sys@dmin123
User user-1 User-1@123

@stevemudie stevemudie removed the Setup Cloud Test Server Setup a test server using Mattermost Cloud label Mar 27, 2020
sowmiyamuthuraman pushed a commit to sowmiyamuthuraman/mattermost-webapp that referenced this pull request Apr 10, 2020
…nned) (mattermost#5031)

* MM-22989 - Adding reply count to root posts in RHS

* Adding conditional for visibility

* MM-22989 - Moving reply count function to utils
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation QA Review Done
Projects
None yet
7 participants