This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
Add custom ESLint rule to prevent passing getState into dispatch #4976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 4, 2020
Merged
lieut-data
approved these changes
Mar 5, 2020
crspeller
approved these changes
Mar 5, 2020
|
Skipping QA review since this is just an infrastructure change, so it won't have any functional changes. |
sowmiyamuthuraman
pushed a commit
to sowmiyamuthuraman/mattermost-webapp
that referenced
this pull request
Apr 10, 2020
…termost#4976) * Add custom ESLint rule to prevent passing getState into dispatch * Update package.json
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was bugging me last week, so I made a custom ESList rule to prevent having to ask people to fix this in their PRs occasionally.
Related PRs
mattermost/eslint-plugin-mattermost#2
mattermost/mattermost-mobile#4010
mattermost/mattermost-redux#1068