Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

Fix timeout issues #4854

Merged
merged 1 commit into from
Feb 8, 2020
Merged

Fix timeout issues #4854

merged 1 commit into from
Feb 8, 2020

Conversation

josephbaylon
Copy link
Contributor

Summary

Fix timeout issues.

  • invitation timeout issues found in cypress builds might be due to new IdleTimeout config which is defaulted to 60s. Before IdleTimeout, it used to read session timeout from ReadTimeout which is 300s
  • I was able to replicate popover message timeout and increased from TINY to SMALL to fix

Ticket Link

none, failing on daily Cypress test

@josephbaylon josephbaylon added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Feb 7, 2020
prapti
prapti approved these changes Feb 7, 2020
View reviewed changes
Copy link
Contributor

@prapti prapti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you @josephbaylon!

@saturninoabril saturninoabril added 4: Reviews Complete All reviewers have approved the pull request QA Review Done and removed 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Feb 8, 2020
@saturninoabril saturninoabril merged commit 662c0a4 into mattermost:master Feb 8, 2020
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Feb 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@prapti prapti prapti approved these changes

@saturninoabril saturninoabril saturninoabril approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation QA Review Done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@josephbaylon @prapti @saturninoabril @amyblais